GNOME Bugzilla – Bug 516178
Scheme error during progress dialog causes freeze
Last modified: 2018-06-29 22:01:09 UTC
Please describe the problem: If a Scheme error occurs during in the qif-to-gnc procedure while a progress bar is visible, the druid freezes and GnuCash must be killed. Steps to reproduce: 1. Cause a Scheme error to occur during the qif-to-gnc procedure after a progress dialog is shown. For example, edit qif-to-gnc.scm and insert a bad expression such as (qwerty) in the code after the call to gnc-progress-dialog-new. 2. Attempt to import a QIF file that is large enough to cause a progress bar to appear. For example, use the QIF file attached to bug 515888. Actual results: The druid becomes frozen when the error occurs. Expected results: The error is handled in the same manner as when there isn't a progress dialog. Does this happen every time? Yes. Other information:
Created attachment 105199 [details] [review] Easy-to-read patch (svn -x -w) Don't apply this patch. Just read it. It is just to make it easier to find the real substance of the patch by ignoring whitespace changes (and there were many, due to indentation from wrapping the entire existing procedure in a new "let"). The full patch, including the whitespace changes, will attached next.
Created attachment 105200 [details] [review] Proposed patch This is the one to apply.
Committed as r16954. Awaiting backport for 2.2.4.
Applied to branches/2.2 as r16972 for GnuCash 2.2.4. Thanks a lot!
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=516178. Please update any external references or bookmarks.