After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 515547 - Need a common API for account setting UI
Need a common API for account setting UI
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Accounts
unspecified
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2008-02-10 10:36 UTC by Xavier Claessens
Modified: 2008-02-10 17:12 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Xavier Claessens 2008-02-10 10:36:12 UTC
Too much code is copy/pasted from empathy-account-widget-jabber.c to other account modules, I think it's possible to have one single module with a generic enough API that can manage all cases. I think glade file are still needed for each protocol but we can have an API like:

GtkWidget *empathy_account_widget_new (glade_file,
    "widget_name_1", "account_param_1",
    "widget_name_2", "account_param_2",
    ...etc...
    NULL);

With a mapping between widget and account parameter it's possible to assign widget's value to the account param.

Possibly that could be done in empathy-account-widget-generic.[ch], if glade_file==NULL it generates a default UI like it does right now, otherwise it uses the provided glade.
Comment 1 Xavier Claessens 2008-02-10 17:12:28 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.