GNOME Bugzilla – Bug 515340
Add a way to prioritise plugin load
Last modified: 2008-02-22 23:16:38 UTC
XrandR, font sizes and sound server setup should probably be high on the list, to avoid resizing/flashing during startup, and allow sounds to be played ASAP. See also bug 466458 comment 10
Maybe the media-keys would need to be in earlier than the sound ;) http://www.grillbar.org/wordpress/?p=24
2008-02-09 Jens Granseuer <jensgr@gmx.net> Support for defining plugin start order got lost in the split from gnome-control-center, but it is essential for some plugins to work correctly. With this change the "Priority" keyword can be used in the ".gnome-settings-plugin" file to set plugin priorities. Priority can take values from 1 upwards, with 1 being maximum priority and 100 being the default if nothing is specified by the plugin. For multiple plugins with identical priority start order is undefined. (bug #515340) * gnome-settings-daemon/gnome-settings-plugins-engine.c: (gnome_settings_plugins_engine_load), (activate_plugin), (compare_location), (compare_priority), (gnome_settings_plugins_engine_load_file), (gnome_settings_plugins_engine_load_all), (gnome_settings_plugins_engine_init), (gnome_settings_plugins_engine_shutdown), (gnome_settings_plugins_engine_get_plugins_list), (gnome_settings_plugins_engine_get_plugin_copyright), (gnome_settings_plugins_engine_get_plugin_priority): * gnome-settings-daemon/gnome-settings-plugins-engine.h: add back support for defining plugin start order What's left now is defining priorities for the plugins we ship. Suggestions welcome.
Created attachment 104907 [details] [review] Fix plugin sorting The result of g_slist_sort should be reassigned to the list variable, afaics.
Right, thanks. Please apply.
Patch committed to trunk, thanks
This bug isn't closed, yet, though. See comment #2.
So, actually, I think it may be better to define the priority in gconf. This way gdm can use a different order if necessary.
I'm going to mark this fixed. We should consider how to prioritize the plugins separately. 2008-02-22 William Jon McCann <jmccann@redhat.com> * data/gnome-settings-daemon.schemas.in: * gnome-settings-daemon/gnome-settings-manager.c: (_load_file): * gnome-settings-daemon/gnome-settings-plugin-info.c: (gnome_settings_plugin_info_set_priority): * gnome-settings-daemon/gnome-settings-plugin-info.h: Allow gconf to override priorities. Set sound plugin priority to 1 (highest). Fixes #515340