After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 515263 - ARIA tooltips should respect presentToolTips setting
ARIA tooltips should respect presentToolTips setting
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: 2.22.0
Assigned To: Scott Haeger
Orca Maintainers
Depends on:
Blocks: 423348
 
 
Reported: 2008-02-08 19:55 UTC by Scott Haeger
Modified: 2008-07-22 19:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
first version of ARIA tooltips should respect presentToolTips setting (1.61 KB, patch)
2008-02-12 18:12 UTC, Scott Haeger 		reviewed Details | Review
second version of ARIA tooltips should respect presentToolTips setting (2.37 KB, patch)
2008-02-14 16:39 UTC, Scott Haeger 		none Details | Review

Description Scott Haeger 2008-02-08 19:55:28 UTC 
ARIA tooltip support should respect presentToolTips setting.
Comment 1 Scott Haeger 2008-02-12 18:12:38 UTC 
Created attachment 105071 [details] [review]
first version of ARIA tooltips should respect presentToolTips setting

This version respects settings.presentToolTips for ARIA 'tooltips' only.  Note that Dojo uses ARIA 'alerts' for tooltips.  I do not believe this is correct so 'alerts' do not respect settings.presentToolTips in this version.
Comment 2 Scott Haeger 2008-02-12 20:58:59 UTC 
To test use the 'alerts' and 'tooltips' links from http://live.gnome.org/Orca/Firefox/ARIAWidgets and change toggle settings.presentToolTips
Comment 3 Willie Walker 2008-02-14 16:15:55 UTC 
(In reply to comment #1)
> Created an attachment (id=105071) [edit]
> first version of ARIA tooltips should respect presentToolTips setting
> 
> This version respects settings.presentToolTips for ARIA 'tooltips' only.  Note
> that Dojo uses ARIA 'alerts' for tooltips.  I do not believe this is correct so
> 'alerts' do not respect settings.presentToolTips in this version.

In looking at the area this is changing, I'm seeing it returning False for isAriaAlert if presentTooltips is False.  I'm not sure that is the right thing to do since it is still an alert even if we don't want to speak it.  

But then...I tried to find the code that was calling isAriaAlert.  Where does that exist?  My grep's in the code only showed the definition of the method, but nobody seems to be calling it.
Comment 4 Scott Haeger 2008-02-14 16:38:28 UTC 
> In looking at the area this is changing, I'm seeing it returning False for
> isAriaAlert if presentTooltips is False.  I'm not sure that is the right thing
> to do since it is still an alert even if we don't want to speak it.  
> 
> But then...I tried to find the code that was calling isAriaAlert.  Where does
> that exist?  My grep's in the code only showed the definition of the method,
> but nobody seems to be calling it.
> 

isAriaAlert() is obsolete and has been removed.  presentTooltips is only respected for ARIA tooltips.  Alerts are unaffected by the setting.  The only problem is that Dojo uses 'alert' for 'tooltip' so Dojo tooltips will always be presented.  

All ARIA widgets that I use for testing are linked from http://live.gnome.org/Orca/Firefox/ARIAWidgets

New patch with isAriaAlert() removed to follow.
Comment 5 Scott Haeger 2008-02-14 16:39:41 UTC 
Created attachment 105255 [details] [review]
second version of ARIA tooltips should respect presentToolTips setting

patch with isAriaAlert() removed.
Comment 6 Willie Walker 2008-02-14 16:57:16 UTC 
(In reply to comment #5)
> Created an attachment (id=105255) [edit]
> second version of ARIA tooltips should respect presentToolTips setting
> 
> patch with isAriaAlert() removed.

Looks awesome.  Thanks!  As long as you test it and pylint it, I say check it in.
Comment 7 Scott Haeger 2008-02-14 17:18:41 UTC 
committed to trunk.  Marked as fixed.