After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 515047 - check for all return/space keys consistently
check for all return/space keys consistently
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2008-02-07 18:47 UTC by Christian Persch
Modified: 2008-02-12 16:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] Consitently check for GDK_Return, GDK_ISO_Enter and GDK_KP_Enter. Consistenly check for GDK_space and GDK_KP_Space. Bug #515047. (9.90 KB, patch)
2008-02-07 18:48 UTC, Christian Persch 		committed Details | Review

Description Christian Persch 2008-02-07 18:47:11 UTC 
Some widgets check for GDK_Return and GDK_KP_Enter, while others also check for GDK_ISO_Enter. Same for GDK_space wrt. GDK_KP_Space. I propose to make widgets consistenly support all enter/space keys.
Comment 1 Christian Persch 2008-02-07 18:48:14 UTC 
Created attachment 104660 [details] [review]
[PATCH] Consitently check for GDK_Return, GDK_ISO_Enter and GDK_KP_Enter. Consistenly check for GDK_space and GDK_KP_Space. Bug #515047.

 gtk/gtkaboutdialog.c        |    3 ++-
 gtk/gtkcolorsel.c           |    2 ++
 gtk/gtkcombo.c              |    4 +++-
 gtk/gtkcombobox.c           |    6 ++++--
 gtk/gtkdnd.c                |    1 +
 gtk/gtkentry.c              |    2 ++
 gtk/gtkfilechooserdefault.c |    3 ++-
 gtk/gtkiconview.c           |    4 ++++
 gtk/gtkmenushell.c          |    5 +++++
 gtk/gtkpaned.c              |    3 +++
 gtk/gtkscalebutton.c        |    2 ++
 gtk/gtktext.c               |    2 ++
 gtk/gtktextview.c           |    1 +
 gtk/gtktreeview.c           |    5 +++++
 gtk/gtkwindow.c             |    5 +++--
 15 files changed, 41 insertions(+), 7 deletions(-)
Comment 2 Matthias Clasen 2008-02-10 05:54:00 UTC 
Looks fine.
Comment 3 Matthias Clasen 2008-02-12 16:02:53 UTC 
2008-02-12  Matthias Clasen  <mclasen@redhat.com>

        * gtk/*.c: Unify the handling of various "Enter" keysyms
        all over the place.  (#515047, Christian Persch)