After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 514937 - Correct initialization of hints in is_multicast_address()
Correct initialization of hints in is_multicast_address()
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal normal
: 0.10.18
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-02-07 10:04 UTC by Peter Kjellerstedt
Modified: 2008-02-07 11:00 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
Clear hints in is_multicast_address() (600 bytes, patch)
2008-02-07 10:11 UTC, Peter Kjellerstedt 		committed Details | Review

Description Peter Kjellerstedt 2008-02-07 10:04:40 UTC 
Please describe the problem:
sebastien@kemper.freedesktop.org made a change in gst-plugins-base/gst-libs/gst/sdp/gstsdpmessage.c where he changed

struct addrinfo hints = {

  .ai_socktype = SOCK_DGRAM   

}; 


into 

struct addrinfo hints;
...
hints.ai_socktype = SOCK_DGRAM;

without taking into account that the old version automatically set all non-mentioned fields to zero. Please apply the attached patch.


Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Peter Kjellerstedt 2008-02-07 10:11:56 UTC 
Created attachment 104622 [details] [review]
Clear hints in is_multicast_address()
Comment 2 Wim Taymans 2008-02-07 11:00:54 UTC 
        Patch by: Peter Kjellerstedt  <pkj at axis com>

        * gst-libs/gst/sdp/gstsdpmessage.c: (is_multicast_address):
        Clear the addrinfo struct using memset. Fixes #514937.