After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 514383 - "Mark all messages as read" dialog needs a Cancel button
"Mark all messages as read" dialog needs a Cancel button
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.22.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2008-02-04 19:03 UTC by Matthew Barnes
Modified: 2008-05-16 19:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot showing wacky spacing (21.61 KB, image/png)
2008-02-04 19:04 UTC, Matthew Barnes
  Details
try (14.81 KB, image/png)
2008-03-28 16:43 UTC, Milan Crha
  Details
proposed evo patch (6.94 KB, patch)
2008-03-28 17:52 UTC, Milan Crha
none Details | Review
Revised patch (7.56 KB, patch)
2008-05-15 14:32 UTC, Matthew Barnes
committed Details | Review
Screenshot (16.65 KB, image/png)
2008-05-15 14:33 UTC, Matthew Barnes
  Details

Description Matthew Barnes 2008-02-04 19:03:48 UTC
Accidentally brought up the "Mark all messages as read" dialog and realized we don't have a Cancel button on that guy.  Also, someone needs to fix the spacing (see screenshot).
Comment 1 Matthew Barnes 2008-02-04 19:04:27 UTC
Created attachment 104421 [details]
Screenshot showing wacky spacing
Comment 2 Matthew Barnes 2008-03-11 00:36:37 UTC
Bumping version to a stable release.
Comment 3 Milan Crha 2008-03-18 15:58:23 UTC
The plugin uses e_error_run with "mail:ask-mark-read", when I add there a cancel button, then it's more uglier than before, the cancel button has same width as the more width button, even when I tried to force not homogeneous for action_area of the dialog. Also text is not wrapped nicely in label, like in bug with the long german text in preferences.
Comment 4 Matthew Barnes 2008-03-18 16:51:06 UTC
I'd suggest, then, not using e-error for that dialog and construct it by hand.  It's simple enough to do (see e-passwords.c for an example).

Cosmetics aside, if I open that dialog by mistake or decide I don't want to mark messages anymore, there's no obvious way to cancel the operation.  It's not clear what clicking the dialog's "X" (close) button will do.
Comment 5 Milan Crha 2008-03-18 17:47:31 UTC
There is one funny thing about it, the dialog has a default action set to "No", thus the "X" is probably same as "for this folder only" (though no clue for that). 

I agree, it will be better to do it by hand here.
Comment 6 Milan Crha 2008-03-18 18:13:02 UTC
Hmm, e-passwords uses also GtkDialog, same as e-error, thus the buttons are same width. It will need our own window, it seems. Or hack the dialog a bit more (changing packing of the child widgets of the action area in the dialog, probably).
Comment 7 Milan Crha 2008-03-28 16:43:19 UTC
Created attachment 108186 [details]
try
Comment 8 Milan Crha 2008-03-28 17:52:04 UTC
Created attachment 108188 [details] [review]
proposed evo patch

for evolution;

There is only one "ugly ugly" comment finally, I found out that gtk_container_set_border_width does what I did before with labels.

Please notice also the change in e-error.c with packing. It should help a bit too, I hope.
Comment 9 Srinivasa Ragavan 2008-04-03 09:02:34 UTC
I assume that Matt would review and approve it :-)
Comment 10 Srinivasa Ragavan 2008-05-14 05:08:55 UTC
Matt, it needs your review :)
Comment 11 Matthew Barnes 2008-05-15 11:08:29 UTC
Looking into this.  Still fighting with label wrapping.
Comment 12 Matthew Barnes 2008-05-15 14:32:30 UTC
Created attachment 110958 [details] [review]
Revised patch

I iterated on Milan's patch a bit and finally managed to beat the line wrapping into submission (with a comment explaining how).
Comment 13 Matthew Barnes 2008-05-15 14:33:38 UTC
Created attachment 110959 [details]
Screenshot
Comment 14 Matthew Barnes 2008-05-15 21:32:15 UTC
/me notes not to take screenshots in Compiz anymore.
Comment 15 Srinivasa Ragavan 2008-05-16 03:32:29 UTC
Seems better Matt.
Comment 16 Matthew Barnes 2008-05-16 19:51:37 UTC
Committed to trunk (revision 35504).