GNOME Bugzilla – Bug 514383
"Mark all messages as read" dialog needs a Cancel button
Last modified: 2008-05-16 19:51:37 UTC
Accidentally brought up the "Mark all messages as read" dialog and realized we don't have a Cancel button on that guy. Also, someone needs to fix the spacing (see screenshot).
Created attachment 104421 [details] Screenshot showing wacky spacing
Bumping version to a stable release.
The plugin uses e_error_run with "mail:ask-mark-read", when I add there a cancel button, then it's more uglier than before, the cancel button has same width as the more width button, even when I tried to force not homogeneous for action_area of the dialog. Also text is not wrapped nicely in label, like in bug with the long german text in preferences.
I'd suggest, then, not using e-error for that dialog and construct it by hand. It's simple enough to do (see e-passwords.c for an example). Cosmetics aside, if I open that dialog by mistake or decide I don't want to mark messages anymore, there's no obvious way to cancel the operation. It's not clear what clicking the dialog's "X" (close) button will do.
There is one funny thing about it, the dialog has a default action set to "No", thus the "X" is probably same as "for this folder only" (though no clue for that). I agree, it will be better to do it by hand here.
Hmm, e-passwords uses also GtkDialog, same as e-error, thus the buttons are same width. It will need our own window, it seems. Or hack the dialog a bit more (changing packing of the child widgets of the action area in the dialog, probably).
Created attachment 108186 [details] try
Created attachment 108188 [details] [review] proposed evo patch for evolution; There is only one "ugly ugly" comment finally, I found out that gtk_container_set_border_width does what I did before with labels. Please notice also the change in e-error.c with packing. It should help a bit too, I hope.
I assume that Matt would review and approve it :-)
Matt, it needs your review :)
Looking into this. Still fighting with label wrapping.
Created attachment 110958 [details] [review] Revised patch I iterated on Milan's patch a bit and finally managed to beat the line wrapping into submission (with a comment explaining how).
Created attachment 110959 [details] Screenshot
/me notes not to take screenshots in Compiz anymore.
Seems better Matt.
Committed to trunk (revision 35504).