GNOME Bugzilla – Bug 514321
warnings to fix in trunk
Last modified: 2008-08-01 19:02:43 UTC
Using File>Open triggers a batch of console warnings: (gthumb:22069): Gtk-WARNING **: Refusing to add non-unique action 'ImageTransformMenu' to action group 'Actions' (gthumb:22069): Gtk-WARNING **: Refusing to add non-unique action 'ImageAutoMenu' to action group 'Actions' (gthumb:22069): Gtk-WARNING **: External_Scripts: missing action External_Scripts (gthumb:22069): GLib-GObject-CRITICAL **: g_object_set: assertion `G_IS_OBJECT (object)' failed The first two also occur in gthumb-2-10. - Mike
Should the viewer have the scripts menu?
Yes, it should. - Mike
Created attachment 104417 [details] [review] Viewer assertions and script menu.
There is also the problem in actualizing the scripts menu when editing. Right now only the browser/viewer instance that was used to call the edit dialog is actualized.
Manuel, Sorry, I was confused. It doesn't matter to me if the Scripts menu is present in the viewer mode. (Is File>Open the only time the viewer mode is active? I never actually use that mode!) If it simplifies anything, the Scripts menu can be added or removed from the viewer mode, either way is fine. There is also a small memory leak that was never fixed (http://code.google.com/p/google-highly-open-participation-gnome/issues/detail?id=104#c40). - Mike
The viewer mode is also called with 'gthumb --viewer path_to_exactly_only_one_image'. In viewer mode the "script menu" is working as the browser mode. The problem that was i saying the comment 4, is not "viewer" related, it affects the browser window. When there is multiples browser windows opened, any change to the scripts menu list in one window, is not reflected to the other browser windows.
Thanks, Manuel! I committed your patch, with some extra code to fix the other viewer warnings (g_object_set: assertion `G_IS_OBJECT (object)' failed). Do you know how to fix the multiple browser issue? It's not a critical issue - I doubt anyone will notice the problem :-) - Mike