After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 513851 - migrate to amazon ECS 4.0
migrate to amazon ECS 4.0
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 526555 537020 540033 (view as bug list)
Depends on:
Blocks: 412853
 
 
Reported: 2008-02-02 10:04 UTC by Jonathan Matthew
Modified: 2008-06-24 21:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Update the Amazon cover fetcher to use the new ECS 4.0 API (7.15 KB, patch)
2008-04-09 09:07 UTC, Maximilian Grothusmann
committed Details | Review
Amazon: Use batch requests (7.63 KB, patch)
2008-04-10 17:05 UTC, Maximilian Grothusmann
committed Details | Review

Description Jonathan Matthew 2008-02-02 10:04:10 UTC
As far as I can tell, we're using version 3.0 of amazon's ECS service to find album art.  According to this announcement:

http://developer.amazonwebservices.com/connect/ann.jspa?annID=164

this version of the service will be shut down after March 31st.  There's a migration guide here:

http://developer.amazonwebservices.com/connect/entry.jspa?categoryID=12&externalID=627

(I'm probably not going to do the work for this myself)
Comment 1 Jonathan Matthew 2008-04-06 22:03:46 UTC
*** Bug 526555 has been marked as a duplicate of this bug. ***
Comment 2 Maximilian Grothusmann 2008-04-09 09:07:04 UTC
Created attachment 108913 [details] [review]
Update the Amazon cover fetcher to use the new ECS 4.0 API

Please test :-)
Comment 3 Jonathan Matthew 2008-04-09 10:40:17 UTC
I haven't tried it, and I don't have any comments about the code, but I think it'd be a good idea to use batch requests (http://docs.amazonwebservices.com/AWSEcommerceService/4-0/PgCombiningOperations.html) to reduce the number of requests we make.
Comment 4 Alex Lancaster 2008-04-09 10:43:13 UTC
This patch fixes Amazon search, thanks!  If no objections from main developer, and if he doesn't beat me too it, I'll look over the patch a bit more carefully and check it in.
Comment 5 Jonathan Matthew 2008-04-09 13:23:40 UTC
Maximilian: we're currently trying to relicense rhythmbox so it can be distributed with GPL-incompatible GStreamer plugins (bug 513617).  Since this is a non-trivial contribution, it would help if you could state here that you agree (or not) with the relicensing.
Comment 6 Jonathan Matthew 2008-04-10 12:27:28 UTC
The code all looks fine, and it seems to work pretty well.
Comment 7 Maximilian Grothusmann 2008-04-10 17:05:23 UTC
Created attachment 109011 [details] [review]
Amazon: Use batch requests

This patch implements batch processing and has to be applied on top of the original ECS-4.0 patch.
Also, I agree with the relicensing. :)
Comment 8 Jonathan Matthew 2008-04-10 22:11:59 UTC
I've committed your patches to svn.  Thank you very much for working on this.
Comment 9 Jonathan Matthew 2008-06-07 01:53:47 UTC
*** Bug 537020 has been marked as a duplicate of this bug. ***
Comment 10 Bastien Nocera 2008-06-24 21:17:25 UTC
*** Bug 540033 has been marked as a duplicate of this bug. ***