After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 513845 - Port gdl to gio
Port gdl to gio
Product: gdl
Classification: Other
Component: general
Other Linux
: Normal normal
: ---
Assigned To: Anjuta maintainers
Anjuta maintainers
Depends on:
Reported: 2008-02-02 08:50 UTC by Johannes Schmid
Modified: 2008-09-02 08:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

patch (1.82 KB, patch)
2008-08-17 17:19 UTC, Ignacio Casal Quinteiro (nacho)
none Details | Review
patch2 (2.04 KB, patch)
2008-08-17 17:28 UTC, Ignacio Casal Quinteiro (nacho)
none Details | Review

Description Johannes Schmid 2008-02-02 08:50:15 UTC
Actually we don't really need to port gdl itself. It would be enough to just kill gdl-icons.[ch] and use g_fileinfo_get_icon() in the modules using it (e.g anjuta). 

That would also kill the gnome-dependency in gdl.
Comment 1 André Klapper 2008-06-18 21:41:05 UTC
Any progress on this?
Comment 2 Johannes Schmid 2008-06-18 23:17:50 UTC
File-manager is ported (see anjuta gio bug), still used in document-manager and symbol-browser but it will disappear from gdl as soon as the others are ported. I am quite confident to fix this at least for gdl for 2.24 though I am not sure if we will be able to fix anything in anjuta.
Comment 3 André Klapper 2008-07-18 09:51:14 UTC
$:andre\> cd gdl/
$:andre\> grep -r vfs .
./gdl/gdl-icons.c:#include <libgnomevfs/gnome-vfs-ops.h>
./gdl/gdl-icons.c:	info = gnome_vfs_file_info_new ();
./gdl/gdl-icons.c:	gnome_vfs_get_file_info (uri, info,
./gdl/gdl-icons.c:	gnome_vfs_file_info_unref (info);
./ libgnomeui-2.0 gnome-vfs-2.0 gtk+-2.0 gdl-1.0
./		gnome-vfs-2.0 >= $GNOME_VFS_REQUIRED,
Comment 4 Ignacio Casal Quinteiro (nacho) 2008-08-17 17:11:14 UTC
It seems right now only symbol-browser uses gdl-icons, shouldn't be difficult to remove this from it.
Comment 5 Ignacio Casal Quinteiro (nacho) 2008-08-17 17:19:54 UTC
Created attachment 116810 [details] [review]

Not sure if this should fix the bug.
Comment 6 Ignacio Casal Quinteiro (nacho) 2008-08-17 17:28:34 UTC
Created attachment 116811 [details] [review]

The first one was just a try. This compiles fine. But untested.
Comment 7 André Klapper 2008-08-17 19:12:44 UTC
Changes in are also required, e.g. removing
any GNOME_VFS_REQUIRED, adding something like GLIB_REQUIRED=2.15.4, and also probably checking for gio-2.0 >= $GLIB_REQUIRED_VERSION in PKG_CHECK_MODULES.

"Probably" because I don't code. :-)
Comment 8 Johannes Schmid 2008-09-02 08:24:14 UTC
Use a much easier approach to remove gdl-icons. Fixed in trunk