GNOME Bugzilla – Bug 513845
Port gdl to gio
Last modified: 2008-09-02 08:24:14 UTC
Actually we don't really need to port gdl itself. It would be enough to just kill gdl-icons.[ch] and use g_fileinfo_get_icon() in the modules using it (e.g anjuta). That would also kill the gnome-dependency in gdl.
Any progress on this?
File-manager is ported (see anjuta gio bug), still used in document-manager and symbol-browser but it will disappear from gdl as soon as the others are ported. I am quite confident to fix this at least for gdl for 2.24 though I am not sure if we will be able to fix anything in anjuta.
$:andre\> cd gdl/ $:andre\> grep -r vfs . ./gdl/gdl-icons.c:#include <libgnomevfs/gnome-vfs-ops.h> ./gdl/gdl-icons.c: info = gnome_vfs_file_info_new (); ./gdl/gdl-icons.c: gnome_vfs_get_file_info (uri, info, ./gdl/gdl-icons.c: gnome_vfs_file_info_unref (info); ./gdl-gnome-1.0.pc.in:Requires: libgnomeui-2.0 gnome-vfs-2.0 gtk+-2.0 gdl-1.0 ./configure.in: gnome-vfs-2.0 >= $GNOME_VFS_REQUIRED,
It seems right now only symbol-browser uses gdl-icons, shouldn't be difficult to remove this from it.
Created attachment 116810 [details] [review] patch Not sure if this should fix the bug.
Created attachment 116811 [details] [review] patch2 The first one was just a try. This compiles fine. But untested.
Changes in configure.in/.ac are also required, e.g. removing any GNOME_VFS_REQUIRED, adding something like GLIB_REQUIRED=2.15.4, and also probably checking for gio-2.0 >= $GLIB_REQUIRED_VERSION in PKG_CHECK_MODULES. "Probably" because I don't code. :-)
Use a much easier approach to remove gdl-icons. Fixed in trunk