After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 513660 - Drop gnome-vfs dependency
Drop gnome-vfs dependency
Product: bug-buddy
Classification: Deprecated
Component: general
Other Linux
: Normal normal
: ---
Assigned To: Bug-buddy Maintainers
Bug-buddy Maintainers
Depends on:
Reported: 2008-02-01 11:31 UTC by Cosimo Cecchi
Modified: 2008-07-14 17:50 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

gio-migration (2.47 KB, patch)
2008-02-01 11:32 UTC, Cosimo Cecchi
none Details | Review
gio-migration v2 (3.09 KB, patch)
2008-04-19 13:41 UTC, Cosimo Cecchi
none Details | Review
gio-migration v2 (real one) (3.27 KB, patch)
2008-04-19 13:46 UTC, Cosimo Cecchi
committed Details | Review

Description Cosimo Cecchi 2008-02-01 11:31:06 UTC
Following patch replaces the few calls of gnome-vfs functions in bug-buddy with gio.
Comment 1 Cosimo Cecchi 2008-02-01 11:32:44 UTC
Created attachment 104192 [details] [review]

This depends on a not yet released GLib, but 2.15.5 should be released for 2.21.91 and 2.16 will be surely released for 2.22.
Comment 2 Christian Persch 2008-02-01 12:13:35 UTC
-	if (gnome_vfs_url_show (link) != GNOME_VFS_OK) {
+	if (g_app_info_launch_default_for_uri (link, NULL, NULL) == FALSE) {

This should use a {Gdk,Eel}AppLaunchContext so it launches on the right screen (the original ought to have used gnome_url_show_on_screen()).
Comment 3 Cosimo Cecchi 2008-02-01 12:30:29 UTC
We can import another eel-app-launch-context.[ch] copy in bug-buddy for this, but I think we'd better either commit this without the launch context and a FIXME for 2.22 and use GdkAppLaunchContext in 2.24 or commit this after 2.22 branching with GdkAppLaunchContext.
Comment 4 Christian Persch 2008-02-06 18:46:37 UTC
I'd say to use #if GTK_CHECK_VERSION (2, 15, 0) for the launch context, and not bother with EelLaunchContext for gtk 2.12. case.
Comment 5 André Klapper 2008-04-07 18:01:07 UTC
*ping*: cosimoc, want to come up with an updated patch?
Comment 6 Cosimo Cecchi 2008-04-19 13:41:20 UTC
Created attachment 109536 [details] [review]
gio-migration v2

Updated patch, sorry if it took so long.
Comment 7 Cosimo Cecchi 2008-04-19 13:46:32 UTC
Created attachment 109538 [details] [review]
gio-migration v2 (real one)

Sorry, I missed an include and messed up indentation for some reason.
Comment 8 Cosimo Cecchi 2008-05-28 11:25:54 UTC
Anyone to review this?
Comment 9 André Klapper 2008-06-22 16:20:49 UTC
fer: PING.
Comment 10 A. Walton 2008-07-14 09:59:08 UTC
Cosimo's second patch looks fine to me.
Comment 11 André Klapper 2008-07-14 10:08:33 UTC
setting patch status. we maybe want to branch for 2.22 before committing, maybe not. :-P
Comment 12 Cosimo Cecchi 2008-07-14 17:50:03 UTC
Ok, I branched for 2.22, pushed the patch to trunk and bumped the version to 2.23.5. Closing as FIXED.

2008-07-14  Cosimo Cecchi  <>

	* src/bug-buddy.c: (link_callback):
	* src/verify-desktop-files.c: (main):
	Port to GIO and bump version to 2.23.5.