After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 513615 - sound-juicer should have a GPL exception
sound-juicer should have a GPL exception
Status: RESOLVED OBSOLETE
Product: sound-juicer
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Sound Juicer Maintainers
Sound Juicer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-02-01 06:02 UTC by Brian Cameron
Modified: 2021-05-17 15:59 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24



Description Brian Cameron 2008-02-01 06:02:54 UTC
sound-juicer is a GPL program.

Totem has a GPL exception that allows the usage of such plugins.  Refer here:

http://svn.gnome.org/viewvc/totem/trunk/license_change?revision=4301&view=markup

Would it be possible for sound-juicer to also have such an exception added so it 
can be distributed on systems with GStreamer plugins that contain IP?
Comment 1 Ross Burton 2008-02-01 10:44:15 UTC
Yes, agreed.

Let's start the relicensing fun with Bastien and Ronald.  Do you agree?
Comment 2 Bastien Nocera 2008-02-01 10:50:34 UTC
Fine by me. gnome-media's shared-library bits for the profiles probably need relicensing as well. Brian, could you file a bug?
Comment 3 Ronald Bultje 2008-02-01 13:26:56 UTC
I only contributed the volume slider and some CD playback bits, right? The volume slider was always LGPL (and isn't that in Gtk+ nowadays?), so that's OK.

For the CD playback, I need to look at that patch and make sure I didn't do any straight copy-pastes from someone else. If not, it's OK with me. Make sure that whatever CD playback element I use is in fact LGPL also, hardcoding it to a GPL element would sort of defeat the whole purpose, because (by hardcoding it) you "include" GPL code (i.e. your code is not independent) and thus the runtime would probably be GPL (${IANAL}).
Comment 4 Brian Cameron 2008-02-01 16:08:13 UTC
See bug 513612 for gnome-media relicising.
Comment 5 Brian Cameron 2008-02-01 17:31:54 UTC
Right, it would defeat the purpose to use a GPL CDDA plugin, like cdparanoia or libcdio.  Unfortunately these are the only CDDA plugins in GStreamer at the moment.

Artem and I at Sun wrote a LGPL CDDA plugin that only uses ioctls and seems to work well enough on Solaris.  Nobody complained about loss of quality or anything when we switched from using libcdio.  Refer to bug 413705.  Perhaps a LGPL option should be included in gst-plugins-good as well, as suggested in that bug report?
Comment 6 Ronald Bultje 2008-02-01 17:45:59 UTC
The key thing is that it needs to not rely on GPL-only CDDA API. There's several ways to do that, but key is that the API is generic, LGPL, ideally there's a LGPL implementation (like yours) and there's no hardcoding of GPL parts.

GSt has plugin categories and such that can assist you in that, and the API is obvious enough, imo. The amount of code needing a patch in s-j is very minor (and since you have the LGPL impl, it seems like you're pretty much there already).
Comment 7 Brian Cameron 2008-03-19 19:42:34 UTC
Any update on whether sound-juicer can be relicensed?

By the way, I understand that the Mozilla Songbird project is planning to add CD playback and ripping support.  They also use GStreamer, and they have a totem-like extension in their licensing already.

I suspect that if sound-juicer cannot figure out how to relicense, that on Solaris we will drop sound-juicer support and switch to using Songbird.  If sound-juicer is able to relicense, I think we would probably ship both.
Comment 8 Ross Burton 2008-03-19 19:51:54 UTC
Some contributors have not replied to my mails, I'll ping again.
Comment 9 Brian Cameron 2008-04-22 01:16:14 UTC
Any update?
Comment 10 Matthew Martin 2008-09-02 15:40:54 UTC
I'm fine with this.
Comment 11 Matthias Clasen 2008-09-02 15:41:11 UTC
I'm fine with relicensing any contributions I have in sound-juicer (though I'm not aware of any, really)
Comment 12 Rob Bradford 2008-09-02 15:41:23 UTC
No problem with relicensing from me.
Comment 13 Sebastien Bacher 2008-09-02 15:47:13 UTC
I agree on the licensing change
Comment 14 Michael Terry 2008-09-02 15:56:06 UTC
Fine with me.
Comment 15 Christophe Fergeau 2008-09-02 16:08:28 UTC
Ok as well if I made significant contributions to s-j
Comment 16 Luca Cavalli 2008-09-02 21:44:24 UTC
No problem from me too.
Comment 17 Paolo Borelli 2008-09-03 15:07:06 UTC
Fine with me (also with regard to the gedit-message-area widget)
Comment 18 Brian Cameron 2008-09-25 20:29:25 UTC
Any update on when the code could be relicensed or who still needs to provide approval?  It would be good to get this issue addressed.  sound-juicer is the only remaining GStreamer-based program that is commonly installed with GNOME that does not have this issue fixed yet.
Comment 19 Bastien Nocera 2008-09-27 00:06:40 UTC
List is here:
http://live.gnome.org/SoundJuicerRelicense
Comment 20 Rich Burridge 2008-09-27 02:50:02 UTC
Fine with me.
Comment 21 Willie Walker 2008-09-27 19:48:47 UTC
Fine by me.  Thanks!
Comment 22 Paolo Maggi 2008-10-01 15:25:08 UTC
I agree on the licensing change (also with regard to the gedit-message-area widget)
Comment 23 Matthias Clasen 2008-10-01 15:30:17 UTC
paolo, talking about gedit-message-area, I was toying with the idea of adding a message area widget to gtk and basing it on that code. Would you be open to lgpl ?
Comment 24 Paolo Maggi 2008-10-01 15:48:35 UTC
Matthias: sure, feel free to relicense it to LGPL
Comment 25 Ignacio Casal Quinteiro (nacho) 2008-10-01 19:22:12 UTC
Fine with me too.
Comment 26 Ghee Teo 2009-02-04 17:59:49 UTC
Fine by me. The only recollection I have was to provided a fix to one of GUI :)
Comment 27 Pascal Terjan 2009-02-04 18:27:28 UTC
That's fine for me, I don't even remember what code I could write :)
Comment 28 Michael Chudobiak 2009-02-04 18:32:46 UTC
Fine by me.
Comment 29 Ted Gould 2009-02-04 18:34:54 UTC
I agree on the licensing change
Comment 30 Brian Geppert 2009-02-04 18:44:45 UTC
Fine by me.  I personally don't like the exception approach instead of using something like the LGPL, but I approve of your decision regardless.
Comment 31 William Lachance 2009-02-04 18:45:24 UTC
Fine by me.
Comment 32 Jonh Wendell 2009-02-04 18:50:01 UTC
Fine to me.
Comment 33 Wouter Bolsterlee (uws) 2009-02-04 19:02:04 UTC
I agree to relicensing of my (minor) contributions.
Comment 34 Pekka Vuorela 2009-02-04 19:05:20 UTC
Fine with me.
Comment 35 Andrzej Polatyński 2009-02-04 19:17:29 UTC
I agree.
Comment 36 Bill O'Shea 2009-02-04 19:21:29 UTC
I agree.
Comment 37 Dave Meikle 2009-02-04 20:26:14 UTC
Fine by me.
Comment 38 Michael Monreal 2009-02-04 20:26:30 UTC
I also agree.
Comment 39 Jaap A. Haitsma 2009-02-04 20:37:24 UTC
Agree
Comment 40 David Mandelberg 2009-02-04 21:17:26 UTC
I agree.
Comment 41 James "Doc" Livingston 2009-02-04 21:48:27 UTC
Fine by me.
Comment 42 Loïc Minier 2009-02-04 22:11:58 UTC
I'm fine with adding the same grant as totem in sound-juicer.
Comment 43 John Thacker 2009-02-05 05:35:47 UTC
Fine with me as well, though my contributions were limited to small bugfixes IIRC.
Comment 44 Carl-Anton Ingmarsson 2009-02-05 12:50:37 UTC
I agree.
Comment 45 Patrick Wade 2009-02-11 16:54:42 UTC
Fine by me.
Comment 46 Ka-Hing Cheung 2009-02-15 23:42:37 UTC
While relicensing a Free application so that non-Free code can be used seems to be a step backward to me, my contribution is minor enough such that I don't want to block the effort. So I guess that's a "yes" from me.

I don't quite understand what sound-juicer needs that would require a non-Free plugin though... but that may be quite offtopic here.
Comment 47 Brian Cameron 2009-02-17 17:43:33 UTC
Ka-Hing, just for the record, the main reason why relicensing sound-juicer with t
this exception is a good thing for many users would be that sound-juicer could be 
shipped with non-free audio codecs.

For example, MP3 audio or AAC are examples of non-free audio formats.  Some users 
may like to rip files from CD to these formats.  However, such support cannot be 
distributed with sound-juicer without this license exception.  Enhancing sound-
juicer so it has such a license exception gives distros the ability to distribute 
sound-juicer with such non-free media support if they desire (and if, of course, 
they also pay any associated licensing fees).

The licensing exception doesn't change the code from being GPL.  It is still
under the GPL after the license exception is added.  The exception just adds
a clarification that distribution with non-free GStreamer codecs is acceptable 
and not a violation of sound-juicer's license.

Note that the other major GStreamer-based media programs in GNOME (rhythmbox, 
totem, and songbird) all have similar license exceptions as proposed here.
Comment 48 Ronald Bultje 2009-02-17 18:01:18 UTC
Brian, please retract your "However, such support cannot be distributed with sound-juicer without this license exception.", this is not true. The "free"-ness of mp3 as a (patented) format can be questioned, but GPL implementations of mp3/aac (e.g. faac/lame), whether legally distributable or not, can be used with a plain GPL sound-juicer, there is nothing wrong with that.
Comment 49 Brian Cameron 2009-02-17 18:17:21 UTC
Apologies if I caused any confusion or spread any FUD in my last posting.

As you say, the example of MP3 may not be a good one since, as you say, there is
some that debate whether it is a free format or not.  Regardless, having the
exception avoids any need to worry about such debate, and also ensures that
people can distribute sound-juicer with any non-free codecs they might desire.

I never intended to suggest that end users cannot build and use whatever GStreamer plugins they wish.  As you say, users can do this if they want.
I only intended to suggest that distributing sound-juicer with non-free media plugins can cause complications.  As you say, it is only an issue with distribution, not with using.  Also, since IP laws vary from country-to-country,
the distribution issues may not be problems in some places or for some users.

Also, I'm not a lawyer, so my opinions shouldn't be considered to have any real authority.  My main interest in seeing this issue addressed is simply to make 
sure that sound-juicer uses the same licensing that has already been approved for
other GStreamer-based media players, so that things are more consistent.
Comment 50 Adam Petaccia 2009-04-09 06:20:50 UTC
Fine with me.
Comment 51 Stefan Oderbolz 2009-04-09 07:40:10 UTC
I agree to the change.
Comment 52 Tim-Philipp Müller 2009-04-09 09:27:22 UTC
I am not sure I agree with the way the issue is presented/framed; particularly the analogy between playback applications and encoding applications, but more generally the - as it seems to me - either conflation or confusion of multiple somewhat different issues. Or whether I'd want sound-juicer to be used in connection with proprietary encoders if it was 'my' application.

However, since my contributions to sound-juicer have been insignificant at best, I'm fine with the relicensing.
Comment 53 Brian Cameron 2009-04-11 04:43:55 UTC
I think there are only 4 people who haven't yet given a positive response: 
Ed Catmur, Stefan Röllin, Christian Persch, and Juan F. Giménez Silva.

- Ed Catmur is only recognized in the ChangeLog for bug #172781.  By my reading
  of this bug report, he did not provide any code.  He seemed to just offer some 
  advice in the bug report, thus the Thanks.
- Stefan Rollin is associated with only bug #440400, and he only provided a
  1-line fix to avoid a crasher.
- Juan F. Giménez Silva is associated with only bug #522909 which added %y
  support to src/sj-extracting.c.  Not a major feature, and one we could perhaps
  consider ripping out if it isn't too important.
- Christian Persch seems the only outstanding person who has contributed more
  significant code changes.

Note, I have send two emails to all these people asking them to respond with 
their feedback, and no response yet.  One in early February and the second a few 
days ago.

Comment 54 Juan F. Giménez Silva 2009-06-04 11:44:48 UTC
I'm sorry for the late response, while I know my "contribution" *sigh* was rather unsignificant, I must have missed the email as I never thought my opinion would matter on such an important decision.

I agree with the proposal.
Comment 55 Stefan Röllin 2009-06-04 16:54:05 UTC
Fine for me.

(Sorry for the late reply - didn't remember that I contributed to sound-juicer.)
Comment 56 gerv 2010-10-13 10:35:19 UTC
Presumably more people have been contributing to S-J since this list was created?

The current developers should add the exception to all the code except that belonging to the last two people, so that the problem doesn't get any worse when new people contribute.

Then, have another go at contacting Christian Persch. I wouldn't worry about Ed Catmur.

You are so close; don't falter now! :-)

Gerv
(who did the Mozilla relicensing!)
Comment 57 GNOME Infrastructure Team 2021-05-17 15:59:30 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/sound-juicer/-/issues/80.