GNOME Bugzilla – Bug 512600
Don't use gnome_vfs_uri_list_parse
Last modified: 2008-02-17 11:15:34 UTC
We should use g_uri_list_extract_uris() instead in totem_action_drop_files() instead, in both totem.c and drop_cb.
I will write a patch. I found this bug through gnome-love. I looked through the code and this looks very straight forward.
As far as testing goes, what do I need to do in totem to get it to execute this section of code?
it's used in a couple of places, but only when parsing drag'n'drops output. Just check that no files are missing, and that drag'n'drops from Mozilla/Firefox work as expected.
Created attachment 105404 [details] [review]
patch to fix bug
This patch does as the bug suggests. Very simple, and testing shows that it works.
The patch is unusable, it seems to have loads of white space changes that bear no relevance to the patch whatsoever.
...and there's already a fix for this bug in my patch for bug #512602, which I probably should've mentioned here when I put it up on Bugzilla (sorry about that).
2008-02-17 Philip Withnall <firstname.lastname@example.org>
* src/totem-playlist.c: (drop_cb):
* src/totem.c: (totem_action_drop_files): Use
g_uri_list_extract_uris instead of gnome_vfs_uri_list_parse
for drop targets. (Closes: #512600)