After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 512261 - We should implement better support for the FF A11y extension
We should implement better support for the FF A11y extension
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.21.x
Other All
: Normal enhancement
: 2.22.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2008-01-26 17:55 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2008-07-22 19:33 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
revision 1 (996 bytes, patch)
2008-02-19 04:08 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2008-01-26 17:55:37 UTC
Regarding the UIUC A11y extension:
(http://firefox.cita.uiuc.edu/downloads/accessext-v1.3.beta1.xpi is the latest beta at the moment.)

Bohdan made this observation on the list:

> 1. Select Navigation, Headings and move to any header. Header 
> will be visually highlighted, but if I press KP_Plus screen 
> reader starts from old position, the focus is not moved to
> heading.

> My tip: press "end" or "home" - cursor will be moved after
> selected heading and you can read the rest of page with 
> KP_Plus.

Will made this response:

> the best thing if it cannot be fixed.  We could potentially
> try to handle this in Orca and force the focus to change if
> see the caret move to a non-focused item, but I'm not sure 
> about how comfortable I am with  us making that change - 
> it might break things elsewhere.

I think this:

We're already doing this with the Find toolbar and FF help. :-)  I agree that we need to be very careful about breakage and will want to write more regression tests before tackling this enhancement, but it certainly would be nice to do.
Comment 1 Joanmarie Diggs (IRC: joanie) 2008-02-19 04:08:19 UTC
Created attachment 105558 [details] [review]
revision 1

This doesn't do anything fancy; merely updates the caretContext so that the user starts out at the line navigated to via the extension when focus is returned to the document.

In working on this, I noticed that the extension seems to prefer moving to the end of the item -- and once it moved just beyond it.  Perhaps it's doing it in order to scroll the item into view? 

Please test, and let me know if something fancier is desired.  Thanks!

(already pylinted and regression tested)
Comment 2 Mike Pedersen 2008-02-19 17:10:05 UTC
I've just tested this patch with latest orca and latest firefox with the extention.  It seems to work quite nicely.  Hopefully this wil give the users requesting this functionality what they are looking for. 
Comment 3 Joanmarie Diggs (IRC: joanie) 2008-02-20 03:12:31 UTC
Thanks Mike.  Patch committed.  Moving to pending.
Comment 4 Mike Pedersen 2008-02-20 22:45:00 UTC
Anyone mind if I leave this one pending until some more users give it a try?  I'd like to see if we get user feedback on weather or not this fits there needs.