After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 511956 - "Custom Notification" not marked for translation; missing border
"Custom Notification" not marked for translation; missing border
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.22.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Milan Crha
Evolution QA team
Depends on:
Blocks: 236276
 
 
Reported: 2008-01-25 02:50 UTC by André Klapper
Modified: 2008-03-27 11:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (20.37 KB, image/png)
2008-01-25 02:50 UTC, André Klapper
  Details
proposed evo patch (2.65 KB, patch)
2008-03-18 14:27 UTC, Milan Crha
committed Details | Review

Description André Klapper 2008-01-25 02:50:15 UTC
1) add a bogus groupwise account
2) right click on the account name in the left pane in the mailer
3) choose "New _Shared Folder..."
4) enter any folder name and choose a folder, click "Create".
5) see the ugly dialog that has resize problems (bug 511950).
6) click "Contacts".
7) add a contact and click "close".
8) click "C_ustomize notification message"
see one of the worst dialogs ever. missing border around the Message text field, and the window title is not marked for translation
Comment 1 André Klapper 2008-01-25 02:50:42 UTC
Created attachment 103700 [details]
screenshot
Comment 2 André Klapper 2008-01-25 02:51:02 UTC
./groupwise-features/share-folder.c:    gtk_window_set_title (GTK_WINDOW (sf->window), "Custom Notification");
Comment 3 André Klapper 2008-01-25 02:56:27 UTC
also see bug 511950, bug 511952, bug 511953, bug 511956, bug 511957.
Comment 4 Matthew Barnes 2008-03-11 00:35:37 UTC
Bumping version to a stable release.
Comment 5 Milan Crha 2008-03-18 14:09:12 UTC
You've right, this is The Winner ;)
Comment 6 Milan Crha 2008-03-18 14:27:24 UTC
Created attachment 107537 [details] [review]
proposed evo patch

for evolution;

I hid the scrollbars too, it seems nicer from my point of view, even I'm not sure what HIG says.
Comment 7 Srinivasa Ragavan 2008-03-27 09:02:48 UTC
Commit to trunk. 

If Andre says OK in bug 511957 then commit this also in stable.
Comment 8 Milan Crha 2008-03-27 11:26:39 UTC
Committed to trunk. Committed revision 35268.

I will close this, even still waiting for Andre's voice.