GNOME Bugzilla – Bug 511414
Building libwnc without gtkdoc installed is impossible.
Last modified: 2008-02-10 03:21:11 UTC
Please describe the problem: Attempting to build libwnck with ./configure --disable-gtk-doc succeeds in configuring and building but fails during make install. gtkdoc.make has changed, specifically the test for gtkdoc-rebase on line 142 changed from: if test `which gtkdoc-rebase` != ""; then \ to: which gtkdoc-rebase >/dev/null && \ which causes: make[2]: *** [install-data-local] Error 1 make[2]: Leaving directory `/home/deryni/source/wnck/libwnck-2.21.5-patched/doc' make[1]: *** [install-am] Error 2 make[1]: Leaving directory `/home/deryni/source/wnck/libwnck-2.21.5-patched/doc' make: *** [install-recursive] Error 1 during 'make install'. Steps to reproduce: 1. Configure libwnck 2.21.5 with --disable-gtk-doc (and don't have gtkdoc installed). 2. Run make. 3. Run make install or sudo make install or whatever. Actual results: The make install run errors out during the installation of the documentation. Expected results: make install should complete successfully. Does this happen every time? Yes. Other information: Is there a reason the test was changed?
Created attachment 103512 [details] [review] Revert the gtkdoc-rebase changes to gtk-doc.make. This patch allows me to install libwnck correctly without having gtk-doc installed. I think some other things (like make dist) might not work without gtk-doc either but I haven't tested them as I haven't needed them. If this isn't a situation you want to remedy that's fine, I just figured I'd put it out there.
We just need to require gtk-doc 1.9.
Am I to understand that response to be you don't care about being able to install libwnck without gtk-doc then? As I stated originally, that's fine (I don't like it but it isn't my project) I'm just trying to make sure I understand.
No, it means that without gtk-doc 1.9, you won't build the API documentation. The error you had probably happened because you had an older gtk-doc.
I do not have gtk-doc at all. Therefore the 'which gtkdoc-rebase' returns nothing, so the which command fails with an error code and causes make to bail out. The previous version of the test (which is all I am suggesting to have restored) uses test on the output of which instead of which directly thus avoiding the error return problem. And further, I'm just not at all certain what the change in question was supposed to fix, work around, or gain. And the problem I mentioned isn't at build time it is at install time, the project fails to install correctly, it does build correctly however.
Ah, hmm, that's a bug in the gtk-doc.make shipped in the tarball, which comes from gtk-doc. I think it has been fixed, though, since the test is right when generating it again from svn.
Ok, so now that I know that gtk-doc.make is pulled directly from the gtk-doc package I was able to track down the change to gtk-doc.make and why it was changed, there was a different issue with the original test that they attempted to fix in revision 519, and then re-fixed with the current bare which test in revision 527. I shall now go post a response to the original bug report for gtk-doc indicating that the refix in 527 is broken for projects using gtk-doc.make when gtk-doc is not installed. Unless you have an alternative suggestion?
Etan: if it's still broken, then you should open a bug against gtk-doc, yes. Thanks for investigating all this!
It appears that the gtk-doc.make file from gtk-doc svn is in fact fixed and that I was misreading it. So all is well in the world. =)