After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 511389 - Orca doesn't always speak a link that regains focus in FF3
Orca doesn't always speak a link that regains focus in FF3
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.21.x
Other All
: Normal normal
: 2.22.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2008-01-22 22:13 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2008-07-22 19:33 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
proposed patch (859 bytes, patch)
2008-01-24 02:09 UTC, Joanmarie Diggs (IRC: joanie) 		none Details | Review
revision 2 (1.78 KB, patch)
2008-01-25 23:50 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2008-01-22 22:13:29 UTC 
From Mike and confirmed by me:

Steps to reproduce:

1. Bring up the bugzilla bug list
2. Down Arrow to the link for a bug
3. Tab forward once to move focus to the next link
4. Shift Tab to move focus back to the link in step 2

Expected results:  We'd speak the link.

Actual results: We don't say a thing. :-(

I can also reproduce this bug using "pre-performance-enhancement Orca," so it must be a caret-moved event or a focus event that we're incorrectly choosing to ignore.
Comment 1 Joanmarie Diggs (IRC: joanie) 2008-01-24 02:09:57 UTC 
Created attachment 103597 [details] [review]
proposed patch

Mike this solves it for me, does it for you?
Comment 2 Mike Pedersen 2008-01-24 16:54:49 UTC 
Seems to work great.  thanks a lot
Comment 3 Joanmarie Diggs (IRC: joanie) 2008-01-25 23:50:15 UTC 
Created attachment 103758 [details] [review]
revision 2

Thanks Mike.  Sadly when I ran the regression test I discovered that we were sometimes speaking images that were links twice as a result.  This version seems to fix the original problem and eliminate the double-speaking that the previous version introduced.  Regression tested and pylinted.  Mike you mind giving this one a spin?  (And my apologies for not running the regression tests before posting the previous version.)
Comment 4 Joanmarie Diggs (IRC: joanie) 2008-01-26 08:10:21 UTC 
Retargeting for 2.21.90.  I think it's good pending Mike's testing.
Comment 5 Mesar Hameed 2008-01-26 13:12:24 UTC 
Works fine for me.
Comment 6 Mike Pedersen 2008-01-28 21:42:08 UTC 
Looks good to me.
Comment 7 Joanmarie Diggs (IRC: joanie) 2008-01-28 21:55:00 UTC 
Thanks guys.  Patch committed.  Moving to pending.