After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 511065 - Use packagekit to detect missing/installed gtk+ theme engines
Use packagekit to detect missing/installed gtk+ theme engines
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] Appearance
unspecified
Other All
: Low enhancement
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
: 515377 (view as bug list)
Depends on: 315286
Blocks:
 
 
Reported: 2008-01-21 16:42 UTC by Jon Bolt
Modified: 2008-05-07 20:24 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
add pk support (8.80 KB, patch)
2008-05-06 19:41 UTC, Jens Granseuer
none Details | Review

Description Jon Bolt 2008-01-21 16:42:39 UTC
It is currently possible to install gtk+ themes without having the required theme engine installed. For example, on my Ubuntu box I use my custom made Murrrine engine theme - however if I do not have the murrine theme engine installed the theme does not render properly. 

A novice user would know what has happed - there is no warning to the user that the theme is not displaying correctly due to a missing theme engine dependancy

What would be really great is that, using packagekit, the user is prompted with a list of dependancies to install if they try to install a theme for an engine that is not currently installed. 

From what I understand the requried theme engine names can be parsed out of the gtkrc file - packagekit could then search for matching themes.

I am not sure what the use case would be if the theme engine cannot be found - for example in Ubuntu extra repositories have to be enabled for the user to install the Murrine - perhaps the theme wont install at all - or some kinda of warning to the user that it wont display correctly.
Comment 1 Jens Granseuer 2008-02-09 10:57:29 UTC
*** Bug 515377 has been marked as a duplicate of this bug. ***
Comment 2 Thomas Wood 2008-02-11 14:12:18 UTC
PackageKit has not even made a stable release yet, so I can't see any integration work being done in the near future. Marking as low priority as a result.
Comment 3 Thomas Wood 2008-04-11 16:29:41 UTC
gnome-theme-manager has been superseded by gnome-appearance-properties.
Comment 4 Richard Hughes 2008-04-11 19:15:53 UTC
It would be interesting for you guys to get involved in the libpackagekit-gnome library, as this is exactly the sort of thing this is designed for.

At the moment libpackagekit-gnome is a simple gobject - is that a problem for you guys? I guess you also need gpk_install_resource ("/usr/lib/exec/random.so") functionality too.

Richard.
Comment 5 Jens Granseuer 2008-04-13 07:56:23 UTC
No, why would a gobject be a problem?
Comment 6 Richard Hughes 2008-04-13 17:14:21 UTC
Excellent. Do you use Fedora? If so, I can send you rpms of the latest stuff with the libpackagekit-gnome library - then it's a trivial case of making PackageKit support optional, and then adding a few lines of code to do the install.
Comment 7 Jens Granseuer 2008-04-13 21:01:38 UTC
No, I don't run any system that pk is targetted at. ;-)
I hope it's also possible to do that with the dummy backend. In any case, I'll try to get the bug that's blocking this one fixed some time soon.
Comment 8 Richard Hughes 2008-04-14 00:25:56 UTC
Yes, we can use the dummy backend for testing, it's super trivial to use. If you download git, give me a shout if you need any help getting it running.
Comment 9 Jens Granseuer 2008-04-28 20:12:59 UTC
Ok, with current trunk, if libpackagekit-gnome is really that easy, it should be pretty trivial to add this now. I for my part haven't managed to build gnome-packagekit due to the PolicyKit dependency, yet.
Comment 10 Richard Hughes 2008-05-05 20:17:39 UTC
Even easier now: http://www.packagekit.org/pk-faq.html#session-methods
Comment 11 Jens Granseuer 2008-05-06 19:41:41 UTC
Created attachment 110479 [details] [review]
add pk support

Hm, that was too easy. Where's the catch?

Well, I guess the most likely catch is that since I can't test it it probably doesn't work... So, testers most welcome. The patch is against g-c-c trunk as of today.

Currently, the "install" button is shown unconditionally. I'd like to hide it when packagekit is not running/available, but I don't know what to check for to determine that. Any suggestions?
Comment 12 Richard Hughes 2008-05-06 21:03:54 UTC
Yes, the PK bits look correct. For the hiding of the install button, you can either detect if gpk is on the bus, or using a configure switch. The former is obviously better. Yell if you want a pointer.
Comment 13 Jens Granseuer 2008-05-07 20:24:45 UTC
I've just committed an evolved version of the patch. Testers still very welcome.