Created attachment 103283 [details] [review]
patch

Looks good.  I remember desrt doing something like this too, but can't find any bugs.

Given the reaction to bug 342921, I don't think we want this patch. Instead, I think something like this:

enum {
  VTE_TERMINAL_BLINK_SYSTEM,
  VTE_TERMINAL_BLINK_ON,
  VTE_TERMINAL_BLINK_OFF
} VteTerminalBlinkMode;

with getter + setter vte_terminal_[sg]et_cursor_blink_mode(), and only use the gtk setting if the mode is SYSTEM. (And setting mode ON/OFF is the replacement of vte_terminal_set_cursor_blinks).
I'm going to update the patch accordingly.

Created attachment 113482 [details] [review]
[PATCH] Bug 510903 – use gtk-cursor-blink setting

 doc/reference/tmpl/vte.sgml    |   18 +++
 doc/reference/vte-sections.txt |    2 +
 src/vte-private.h              |   10 +-
 src/vte.c                      |  234 +++++++++++++++++++++++++++-------------
 src/vte.h                      |   13 ++-
 5 files changed, 197 insertions(+), 80 deletions(-)

Looks good.

        * doc/reference/tmpl/vte.sgml:
        * doc/reference/vte-sections.txt:
        * src/vte-private.h:
        * src/vte.c:
        * src/vte.h: Make the cursor blinking follow the gtk setting by
        default, with a possible override.

'kay so how does one go about disabling the bloody blinking?