After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 510870 - Port libgnome-desktop to gio
Port libgnome-desktop to gio
Product: gnome-desktop
Classification: Core
Component: libgnome-desktop
Other Linux
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
Depends on:
Reported: 2008-01-20 18:45 UTC by Vincent Untz
Modified: 2008-02-25 01:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

First draft if the patch (25.41 KB, patch)
2008-01-20 18:47 UTC, Vincent Untz
committed Details | Review

Description Vincent Untz 2008-01-20 18:45:32 UTC
Attaching a first patch...
Comment 1 Vincent Untz 2008-01-20 18:47:07 UTC
Created attachment 103273 [details] [review]
First draft if the patch

I didn't port GnomeBg.

I very quickly tested, and it seemed to work, but someone needs to do a careful check, I guess. Attaching the patch now so it doesn't get lost. Maybe I'll have time soon to finish it.
Comment 2 Luca Ferretti 2008-01-24 16:59:10 UTC
Vincent, it seems there is no g_file_input_stream_seek() in my gio installation...

gnome-desktop-item.c: In function 'readbuf_rewind':
gnome-desktop-item.c:275: warning: implicit declaration of function 'g_file_input_stream_seek'
gnome-desktop-item.c:275: warning: nested extern declaration of 'g_file_input_stream_seek'

There is, instead:

gboolean            g_seekable_seek       (GSeekable *seekable,
                                           goffset offset,
                                           GSeekType type,
                                           GCancellable *cancellable,
                                           GError **error);
Comment 3 Vincent Untz 2008-01-24 17:43:19 UTC
Ah, it probably got removed :-)
Thanks for pointing this out! I'll fix the patch when I actually will work on it again.

(fwiw, I think we can remove the parts where we canonicalize uris)
Comment 4 Soren Sandmann Pedersen 2008-01-25 18:22:00 UTC
FWIW, porting GnomeBG should be straight-forward. The main issue is GnomeThumbnailFactory which uses gnome-vfs internally.

Ignoring that issue, I'll take care of porting GnomeBG.
Comment 5 Vincent Untz 2008-02-11 18:14:36 UTC
I've committed my (modified) patch and porte GnomeBG. Søren, you should probably check that I didn't mess GnomeBG, but it was easy...
Comment 6 David Zeuthen (not reading bugmail) 2008-02-25 01:01:12 UTC
FYI I believe the fix GnomeThumbnailFactory is in bug 517276.