GNOME Bugzilla – Bug 510870
Port libgnome-desktop to gio
Last modified: 2008-02-25 01:01:12 UTC
Attaching a first patch...
Created attachment 103273 [details] [review]
First draft if the patch
I didn't port GnomeBg.
I very quickly tested, and it seemed to work, but someone needs to do a careful check, I guess. Attaching the patch now so it doesn't get lost. Maybe I'll have time soon to finish it.
Vincent, it seems there is no g_file_input_stream_seek() in my gio installation...
gnome-desktop-item.c: In function 'readbuf_rewind':
gnome-desktop-item.c:275: warning: implicit declaration of function 'g_file_input_stream_seek'
gnome-desktop-item.c:275: warning: nested extern declaration of 'g_file_input_stream_seek'
There is, instead:
gboolean g_seekable_seek (GSeekable *seekable,
Ah, it probably got removed :-)
Thanks for pointing this out! I'll fix the patch when I actually will work on it again.
(fwiw, I think we can remove the parts where we canonicalize uris)
FWIW, porting GnomeBG should be straight-forward. The main issue is GnomeThumbnailFactory which uses gnome-vfs internally.
Ignoring that issue, I'll take care of porting GnomeBG.
I've committed my (modified) patch and porte GnomeBG. Søren, you should probably check that I didn't mess GnomeBG, but it was easy...
FYI I believe the fix GnomeThumbnailFactory is in bug 517276.