GNOME Bugzilla – Bug 510478
Character navigation in FF wraps from bottom of file to top
Last modified: 2008-07-22 19:33:26 UTC
As originally reported by Jon: http://bugzilla.gnome.org/show_bug.cgi?id=509482#c4 Arrowing right beyond the last line of webpage cycles up to start. At start arrowing left does not take the user to bottom.
Created attachment 103768 [details] [review] revision 1 The question is, what do we do/say when we get to the very end? And for that matter, even though we don't wrap to the bottom from the top, we don't say anything either. So, should we: 1. Say nothing at all and allow the user to infer from the silence where they are/that they can't go even further? 2. Say "Top of File" at the top and "End of File" at the bottom? 3. Just repeat the current character, which tells the user that their keystroke is being acknowledged and processed. 4. Something else? Mike, I need your input. In the meantime, revision 1 of this patch stops the wrapping (i.e. fixes the bug) and uses approach 3 for feedback to the user. Approach 1 and 2 should be just about as easy. Let me know. Thanks. Pylinted already. The regression tests take awhile to run and it's nearly 3 AM, so I'll start the tests and go to bed. <smile> But to be honest, our regression tests don't do very much testing w.r.t. character-by-character navigation. I need to add more tests on that front....
Jon, I'm adding you to the CC list. This bug is what you reported on bug 509482: > Sorry, maybe it should come under a diffrent bug, but here it is > for now: arrowing right beyond the last line of webpage cycles > up to start. at start arrowing left does not take the user to > bottom. Please give the attached patch a try. Also, I'm interested in your feedback on the "what should we say" question I asked of Mike in my previous comment. Thanks much!! P.S. Guys, I'd be super happy if we can get this in for 2.21.90. <smile> If y'all are around this weekend and bored and want to pass the time testing.... <grin>
Joanie, Bug fixed, thanks! regarding user feedback: either alternative 1 or 3 is fine, although for personal preference 1 is more likeable. If i wish to get to top of page, i keep up arrow pressed, if it silences then i know i've arrived. If "top of page" is echoed, i may have held the key for too long and the message gets repeated, which would be frustrating, because i would then want to be able to move on immediately. Mike, what is your feeling on this?
I personally prefer option 1 because it follows what we do in applications such as gedit.
Okey dokey guys. Thanks! New patch in a little bit.
Created attachment 103796 [details] [review] revision 2 Please test. Thanks.
Works great. thanks
Thanks Mike. Patch committed. Moving to pending.
works great. thanks
Thanks Mike. Closing as FIXED.