After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 509888 - Wrong usage of libgweather locations_file
Wrong usage of libgweather locations_file
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: clock
2.21.x
Other Linux
: Normal major
: ---
Assigned To: Panel Maintainers
Panel Maintainers
: 511458 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-01-16 12:50 UTC by Patryk Zawadzki
Modified: 2008-01-27 23:20 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
Proposed patch (545 bytes, patch)
2008-01-16 12:51 UTC, Patryk Zawadzki 		none Details | Review
Proposed fix (589 bytes, patch)
2008-01-16 17:18 UTC, Patryk Zawadzki 		none Details | Review
Actual fix (1.48 KB, patch)
2008-01-16 17:30 UTC, Patryk Zawadzki 		committed Details | Review

Description Patryk Zawadzki 2008-01-16 12:50:32 UTC 
As the variable is clearly named locations_file, it points to the Locations.xml file, not the directory that contains it. Therefore gweather-xml.c actually tries to load /usr/share/libgweather/Locations.xmlLocations.xml
Comment 1 Patryk Zawadzki 2008-01-16 12:51:30 UTC 
Created attachment 102990 [details] [review]
Proposed patch

This patch makes the clock applet use the verbatim string as returned by pkg-config
Comment 2 Patryk Zawadzki 2008-01-16 17:18:52 UTC 
Created attachment 103005 [details] [review]
Proposed fix

Actually forget about that patch, I've also noticed that there is an #ifdef that is nowhere mentioned in the whole code base. This is a better patch (removing the check as it depends on libgweather anyway).
Comment 3 Patryk Zawadzki 2008-01-16 17:30:28 UTC 
Created attachment 103007 [details] [review]
Actual fix

Ah... neeeeeed moooore cofeeeee. This is the actual fix, obviously adding the missing declarations instead of removing the checks as the path is needed for it to work.
Comment 4 Callum McKenzie 2008-01-17 08:03:24 UTC 
Just a quick note from the gnome-applets side: This is technically a change in libgweather so it could be claimed that this isn't a gnome-panel bug. However, I like the new way better, so I changed gnome-applets to behave this way and I think gnome-panel should too.
Comment 5 Pawel Worach 2008-01-23 06:57:15 UTC 
*** Bug 511458 has been marked as a duplicate of this bug. ***
Comment 6 Vincent Untz 2008-01-27 23:20:20 UTC 
Thanks.