GNOME Bugzilla – Bug 509068
We should prevent the user from arrowing into combo boxes in FF
Last modified: 2008-07-22 19:33:03 UTC
It is still possible to arrow into a combo box if the circumstances are just right. At this point setCaretPosition() grabs focus on the combo box. While we have some (and are working on other) "escape mechanisms", I am of the opinion that we just shouldn't allow users to arrow into a combo box period. :-) My suggestion is that we treat combo boxes much the same way that we do lists in forms, namely: If we were about to setCaretPosition() on a combo box, instead set it to the caret offset within the parent that immediately precedes it. The announcement of the combo box should alert the user that they can do something (e.g. tab into it). Tabbing and using structural navigation to move among form fields would still grab focus (just like with lists). Finally, we already have Alt+Down Arrow to expand a combo box if a menu item somehow was arrowed into. This handler should also check to see if we're at a combo box (but not in a menu item). Patch to follow.
Created attachment 102705 [details] [review] revision 1 This patch does what I proposed in the opening report. Mike please test. Thanks!
I think this is the correct approach. This should always keep users from ever getting stuck in comboboxes when they didn't intend to be their.
That's the idea anyway. <smile> Will, please review.
Looks good to me. Thanks, and please commit assuming you've tested this and it pylints to a 10.00. :-) PS - I wonder if some day we'll end up doing the same for text areas.
Patch committed. Moving to pending.
Closing this one as FIXED as 2.21.5 has come and gone. It should not introduce regressions, but if it does/has, we can reopen or file a new bug.