GNOME Bugzilla – Bug 509036
Strings with numbers should rather use %d
Last modified: 2017-10-29 00:58:09 UTC
Nautilus PO file has many unnecassary, localization unfriendly strings. Here are: * all *% strings like: #: ../libnautilus-private/nautilus-global-preferences.c:76 #, no-c-format msgid "25%" msgstr "" #: ../libnautilus-private/nautilus-global-preferences.c:78 #, no-c-format msgid "50%" msgstr "" and alike, it should be replaced by one "%d%s" or some thing (%d for the number and %s for the sign) also: #: ../libnautilus-private/nautilus-global-preferences.c:92 msgid "100 K" msgstr "" #: ../libnautilus-private/nautilus-global-preferences.c:93 msgid "500 K" msgstr "" which is the same issue. For Arabic this is a big problem, as we have to sets of digits and rely on using localized formate code (%Id etc...) for chosing the correct set according to locale.
msgid "25%" this MUST be translated, some languages use another order (% at the start) and other numbers. #: ../libnautilus-private/nautilus-global-preferences.c:93 msgid "500 K" > which is the same issue. For Arabic this is a big problem, as we have to > sets of digits and rely on using localized formate code (%Id etc...) for > chosing the correct set according to locale. ...but what exactly do you propose here?
Yes, Andre, we use it. The point is, they should just offer "%d" with a translator comment, and translators are free to make it %Id. Why this is a better approach: Arabic has about 23 locales, and we have just one ar.po , what do we choose? arabic or arabic-hindu numerals? but if we leave it to %Id, it's up to the locale to decide, ar_EG would use arabic-hindu, while ar_DZ would use the normal Arabic numerals. As for the percent sign, offer it as a separate character, but we won't make use of it for Arabic for now because it is too much effort to have 23 ar_XX.po files. But may be it will be used for other languages. > ...but what exactly do you propose here? Do away with the numbers, generate them in code and offer "%d" for translation, with a translator comment.
ah... got it (hopefully), thanks. wanna come up with a patch?
Changing component as a part of ongoing bug reorganisation work.
The original strings don't exist anymore in 3.1.4, however there are: #: ../src/nautilus-file-management-properties.ui.h:1 msgid "1 GB" #: ../src/nautilus-file-management-properties.ui.h:2 msgid "1 MB" #: ../src/nautilus-file-management-properties.ui.h:3 msgid "10 MB" #: ../src/nautilus-file-management-properties.ui.h:4 msgid "100 KB" #: ../src/nautilus-file-management-properties.ui.h:5 msgid "100 MB" #: ../src/nautilus-file-management-properties.ui.h:7 msgid "100%" #: ../src/nautilus-file-management-properties.ui.h:9 msgid "150%" #: ../src/nautilus-file-management-properties.ui.h:10 msgid "2 GB" #: ../src/nautilus-file-management-properties.ui.h:12 msgid "200%" #: ../src/nautilus-file-management-properties.ui.h:13 msgid "3 MB" #: ../src/nautilus-file-management-properties.ui.h:15 msgid "33%" #: ../src/nautilus-file-management-properties.ui.h:16 msgid "4 GB" #: ../src/nautilus-file-management-properties.ui.h:18 msgid "400%" #: ../src/nautilus-file-management-properties.ui.h:19 msgid "5 MB" #: ../src/nautilus-file-management-properties.ui.h:21 msgid "50%" #: ../src/nautilus-file-management-properties.ui.h:22 msgid "500 KB" #: ../src/nautilus-file-management-properties.ui.h:24 msgid "66%"
Andre, what exactly is needed here?
Basically: Replacing numbers by %d (?) so "500 KB" becomes "%d KB". "KB", "MB" etc do have translations in some languages, but I don't see any sense in translating numbers themselves.
I'm actually not sure we want that option in nautilus preferences, we should came up with a common usable default value. Deferring to 3.20 to see if we get rid of that preference.
Removing milestone, not sure this is needed.
What about using a spin button and a combo box for unit selection?
(In reply to Ernestas Kulik from comment #10) > What about using a spin button and a combo box for unit selection? I think the only unit that makes sense is MB, why would you want GB or KB?
(In reply to Carlos Soriano from comment #11) > I think the only unit that makes sense is MB, why would you want GB or KB? Yeah, you’re right.
(In reply to Ernestas Kulik from comment #12) > (In reply to Carlos Soriano from comment #11) > > I think the only unit that makes sense is MB, why would you want GB or KB? > > Yeah, you’re right. No, he’s not. As I told him on IRC, video files can easily reach above 1GB and they deserve a thumbnail too. I have set my preference to the maximum (4GB).
(In reply to Alexandre Franke from comment #13) > (In reply to Ernestas Kulik from comment #12) > > (In reply to Carlos Soriano from comment #11) > > > I think the only unit that makes sense is MB, why would you want GB or KB? > > > > Yeah, you’re right. > > No, he’s not. As I told him on IRC, video files can easily reach above 1GB > and they deserve a thumbnail too. I have set my preference to the maximum > (4GB). I’ve only just realized that the setting is ignored on my machine. I always get thumbnails for my video files and never had to tweak it.
(In reply to Ernestas Kulik from comment #14) > I’ve only just realized that the setting is ignored on my machine. I always > get thumbnails for my video files and never had to tweak it. Or maybe not. Just coincidental.
There are no such strings in Nautilus anymore.