After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 508760 - Compilatio warning fix
Compilatio warning fix
Status: RESOLVED WONTFIX
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2008-01-11 13:23 UTC by Philip Van Hoof
Modified: 2009-10-15 02:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fixes a compilation warning (531 bytes, patch)
2008-01-11 13:23 UTC, Philip Van Hoof 		none Details | Review

Description Philip Van Hoof 2008-01-11 13:23:03 UTC 
Will attach a patch
Comment 1 Philip Van Hoof 2008-01-11 13:23:28 UTC 
Created attachment 102589 [details] [review]
Fixes a compilation warning
Comment 2 Philip Van Hoof 2008-01-11 13:24:38 UTC 
For the approver: This is a very small change. Feel free to just commit, to save time (if that's more easy for you). Else let me know if I can.
Comment 3 Johan (not receiving bugmail) Dahlin 2008-03-03 01:22:53 UTC 
2008-03-02  Johan Dahlin  <johan@gnome.org>

	* gtk/gtkitemfactory.h: Use void instead of empty arguments.
	(#508760, Philip Van Hoof)
Comment 4 Philip Van Hoof 2008-03-03 17:37:57 UTC 
Thanks
Comment 5 Stephen Fisher 2008-03-09 05:42:45 UTC 
This change broke the Gtk+ API.  I now get a warning when compiling the project that I am a committer for (Wireshark) when using GtkItemFactoryCallback as a parameter in a function.  We treat warnings as errors so I can't compile with the latest Gtk+ trunk anymore.

There is even an explanation above the changed Gtk+ line stating that () must be used to avoid breaking compatibility.  It has been changed to (void) as of SVN rev 19694 (which is how I found this bug).
Comment 6 Matthias Clasen 2008-03-09 21:37:36 UTC 
Yeah, this is not ok and needs to be reverted.
Comment 7 Johan (not receiving bugmail) Dahlin 2008-03-09 22:58:00 UTC 
This has been reverted, closing as WONTFIX.
Comment 8 Lennart Poettering 2009-10-15 02:12:22 UTC 
Bug 598508 includes better fix.