After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 507938 - gio doesn't build due to glib API changes
gio doesn't build due to glib API changes
Status: RESOLVED FIXED
Product: gnome-menus
Classification: Core
Component: libgnome-menu
2.21.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-menus dummy account
gnome-menus dummy account
Depends on:
Blocks:
 
 
Reported: 2008-01-07 21:53 UTC by Sebastien Bacher
Modified: 2008-01-08 12:42 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
updated to the gio changes and require current version (1.96 KB, patch)
2008-01-07 21:58 UTC, Sebastien Bacher 		none Details | Review
Improved fix (3.09 KB, patch)
2008-01-08 11:07 UTC, Wouter Bolsterlee (uws) 		needs-work Details | Review
Improved fix (2.25 KB, patch)
2008-01-08 12:32 UTC, Wouter Bolsterlee (uws) 		none Details | Review
same patch + added configure changes (2.85 KB, patch)
2008-01-08 12:34 UTC, Wouter Bolsterlee (uws) 		committed Details | Review

Description Sebastien Bacher 2008-01-07 21:53:59 UTC 
The code needs to be updated due to gio changes
Comment 1 Sebastien Bacher 2008-01-07 21:58:20 UTC 
Created attachment 102349 [details] [review]
updated to the gio changes and require current version

Those changes make it build correctly using the current gio version
Comment 2 Wouter Bolsterlee (uws) 2008-01-08 11:07:44 UTC 
Created attachment 102384 [details] [review]
Improved fix

Improved patch.
Comment 3 Alexander Larsson 2008-01-08 12:15:38 UTC 
That is not right.
You should still use g_file_monitor_directory(), its just that it now returns a GFileMonitor object.
Comment 4 Wouter Bolsterlee (uws) 2008-01-08 12:29:16 UTC 
ok will fix
Comment 5 Wouter Bolsterlee (uws) 2008-01-08 12:32:02 UTC 
Created attachment 102389 [details] [review]
Improved fix

Incorporated Alex's comments.
Comment 6 Wouter Bolsterlee (uws) 2008-01-08 12:34:25 UTC 
Created attachment 102390 [details] [review]
same patch + added configure changes

Previous patch was made from the wrong working directory
Comment 7 Alexander Larsson 2008-01-08 12:37:00 UTC 
looks good to me
Comment 8 Wouter Bolsterlee (uws) 2008-01-08 12:42:29 UTC 
Fixed in SVN after ack from vuntz.