After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 507856 - Use first name and for myself "me" in chat windows
Use first name and for myself "me" in chat windows
Status: RESOLVED OBSOLETE
Product: empathy
Classification: Core
Component: Chat
2.27.x
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2008-01-07 16:10 UTC by Jaap A. Haitsma
Modified: 2018-05-22 13:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use "Me" for myself in chat windows (1.28 KB, patch)
2010-12-23 08:55 UTC, Chandni Verma
reviewed Details | Review

Description Jaap A. Haitsma 2008-01-07 16:10:30 UTC
Having a discusion window that shows full names every time seems a bit wierd

Xavier Claessens: hello jaap
Jaap Haitsma: hello Xavier
Xavier Claessens: How are you?
Jaap Haitsma: fine and you?
Xavier Claessens: fine, thanks

I propose to use the same approach as google talk does

Xavier: hello jaap
Me: hello Xavier
Xavier: How are you?
Me: fine and you?
Xavier: fine, thanks
Comment 1 Guillaume Desmottes 2008-04-13 17:25:48 UTC
Seems a sane approach to me but I'm not sure if that should be the default or not. Maybe as an option ?
Comment 2 Frederic Peters 2008-04-13 19:56:12 UTC
Note this could be fixed easily with support for Adium message styles (see bug 522069).
Comment 3 Xavier Claessens 2008-09-07 16:32:25 UTC
Adium themes doesn't make this easier. Displaying "me" instead of user's name is easy. But we don't know what is the first/last name of contacts, we only have an alias which could be anything.
Comment 4 William Jon McCann 2009-08-28 16:19:33 UTC
Using "Me" sounds like a good idea to me.  Maybe that part shouldn't block on figuring out the first name issue?
Comment 5 Chandni Verma 2010-12-23 08:55:21 UTC
Created attachment 176926 [details] [review]
Use "Me" for myself in chat windows

Pushed in branch: http://gitorious.org/glassrose-gnome/empathy/commits/Use-Me-in-chats-507856
Comment 6 Guillaume Desmottes 2010-12-24 12:40:48 UTC
Review of attachment 176926 [details] [review]:

I don't know the theme code very well; but does this work with classic and adium themes? In private and muc chats?

::: libempathy-gtk/empathy-theme-irc.c
@@ +90,3 @@
 	/* The nickname. */
+	my_nick = tp_account_get_nickname (empathy_contact_get_account (contact));
+	if (!g_strcmp0 (name, my_nick)) {

Why not just use empathy_contact_is_user() ?
Comment 7 Chandni Verma 2010-12-24 13:46:49 UTC
I have not made any theme specific change. Also, I feel the use of "theme" in the filename is a misnomer.
Yes, it works with private chats and MUCs.

I have made the other changes and pushed them to my public repository http://gitorious.org/glassrose-gnome/empathy/commits/Use-Me-in-chats-507856
Comment 8 Chandni Verma 2010-12-24 14:27:34 UTC
(In reply to comment #7)
> I have not made any theme specific change. Also, I feel the use of "theme" in
> the filename is a misnomer.
> Yes, it works with private chats and MUCs.
> 
> I have made the other changes and pushed them to my public repository
> http://gitorious.org/glassrose-gnome/empathy/commits/Use-Me-in-chats-507856

Also changed "Me:" to "Me: "
Comment 9 Petr Tomasek 2010-12-27 08:50:06 UTC
PLEASE, let this be an option and not a hardcoded solution!
Comment 10 Sjoerd Simons 2010-12-27 11:37:54 UTC
Seems like a really bad idea to me, at best it should be enabled optionally. We already had some usability feedback indicating that users had some issues understanding (and were concerened about) what they looked to to others. This will only make the situation worse in themes that show user names. 

Also note that in a Muc enviroment it's impossible for two users to have a identical in-muc alias, but they can happily use Me as the alias on most protocols, for extra confusion. for the local user. (I didn't say that!?). And i for one would get quite annoyed in this case if i couldn't see how my nick was shown to others :)

Either we should display things completely different (say speec bubbles and avatars instead of names, iChat style) or use the name as the remote user will see it. But not something that might look like how another person might see it, but isn't actually (Googles solution has the same issue here).

Tbh, i wonder if not everyone in this thread completely misunderstood what google is actually doing. Are we sure they're not just setting the alias to something simple instead of the users full name, so actually local and remote are showing the same thing? An easier way to set ones alias would be much more useful then this workaround, and really well, if you want others to see you with your fullname, then you should yourself as well :)
Comment 11 Alex Shpilkin 2013-03-14 22:11:17 UTC
GTalk does use a hardcoded "me" as a matter of fact, but it doesn't need to deal with complications like MUCs. Pidgin, on the other hand, lets the user configure the "me" string explicitly, so that the local and remote views match by default, but don't if explicitly configured not to.
Comment 12 GNOME Infrastructure Team 2018-05-22 13:05:25 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/empathy/issues/6.