After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 507484 - Code typos
Code typos
Status: RESOLVED FIXED
Product: libcroco
Classification: Core
Component: General
0.6.x
Other All
: Normal normal
: ---
Assigned To: libcroco maintainers
libcroco maintainers
Depends on:
Blocks:
 
 
Reported: 2008-01-05 14:21 UTC by Mark Rogers
Modified: 2015-10-31 19:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix typo in logical condition (1.18 KB, patch)
2015-03-19 17:51 UTC, Boris Egorov 		committed Details | Review

Description Mark Rogers 2008-01-05 14:21:42 UTC 
Please describe the problem:
cr-simple-sel.c
line 256 current:
if (cur_sel->type_mask | TYPE_SELECTOR) {
should be:
if (cur_sel->type_mask & TYPE_SELECTOR) {

cr-fonts.c
line 774 current:
        } else if (a_weight == FONT_WEIGHT_BOLDER
                   || a_weight == FONT_WEIGHT_BOLDER) {
                cr_utils_trace_info ("FONT_WEIGHT_BOLDER or FONT_WEIGHT_LIGHTER should not appear here") ;
should be:
        } else if (a_weight == FONT_WEIGHT_BOLDER
                   || a_weight == FONT_WEIGHT_LIGHTER) {
                cr_utils_trace_info ("FONT_WEIGHT_BOLDER or FONT_WEIGHT_LIGHTER should not appear here") ;




Steps to reproduce:
1. Compile code in Visual Studio 2005 with /analyze option


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Mark Rogers 2008-01-05 14:26:06 UTC 
The same option reveals a potential crash in cr_tknzr_destroy

line 2767 current:
if (PRIVATE (a_this)->token_cache) {

should be:
if (PRIVATE (a_this) && PRIVATE (a_this)->token_cache) {
Comment 2 Boris Egorov 2015-03-19 17:51:30 UTC 
Created attachment 299857 [details] [review]
Fix typo in logical condition
Comment 3 Boris Egorov 2015-03-19 17:51:45 UTC 
Issue in cr-fonts.c already fixed: https://git.gnome.org/browse/libcroco/commit/?id=670e3ee116f48118985f38c5ae97df5a42808822
Comment 4 Ignacio Casal Quinteiro (nacho) 2015-10-31 19:22:18 UTC 
Thanks for the patch.