After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 507067 - Can't save pictures embedded in HTML Mail when picture = link
Can't save pictures embedded in HTML Mail when picture = link
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.22.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2008-01-03 17:22 UTC by André Klapper
Modified: 2013-09-13 00:58 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
proposed evo patch (6.70 KB, patch)
2008-01-03 19:31 UTC, Milan Crha 		committed Details | Review

Description André Klapper 2008-01-03 17:22:09 UTC 
as seen on TV and in bug 317823 comment 27, the fix for bug 317823 does not cover images that are links.

if this bug does not get addressed immediately and if a patch will not be attached in the next 5 minutes, i will quit this project! i will!
Comment 1 André Klapper 2008-01-03 17:35:02 UTC 
ok. i'm out. ;-)
Comment 2 Milan Crha 2008-01-03 19:31:44 UTC 
Created attachment 102060 [details] [review]
proposed evo patch

for evolution;

oh jee, oh jee, what did I do, what did I do... ;)
I had the patch ready, but then I tried if it's freed correctly, and it wasn't and I was doing this all the time since the five minutes limit left. Really pity.

Anyway, this works much better than the previous patch, even it's a bit hacky.
I found  possible leak in my previous code too. So fixed also.
Comment 3 Srinivasa Ragavan 2008-01-10 10:33:44 UTC 
Milan looks fine. Just add (...) for huge urls and shorten them.
Comment 4 Milan Crha 2008-01-10 12:06:11 UTC 
Committed to trunk. Committed revision 34790.

The patch committed to trunk includes the shortening code, thanks for finding this, srag. I will close this bug, but fell free to reopen or open other to your work about "already saved images should show puri menu, not url menu".
It's up on you, srag.