After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 506874 - Flat review should support status bars that have accessible text and children
Flat review should support status bars that have accessible text and children
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
unspecified
Other All
: Normal major
: 2.22.0
Assigned To: Rich Burridge
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-01-02 16:21 UTC by Willie Walker
Modified: 2008-07-22 19:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Revision #1 (1.63 KB, patch)
2008-01-14 21:27 UTC, Rich Burridge 		none Details | Review
Alternative patch (812 bytes, patch)
2008-01-14 22:56 UTC, Willie Walker 		committed Details | Review
Patch to address regression test (1.04 KB, patch)
2008-02-10 17:29 UTC, Willie Walker 		committed Details | Review

Description Willie Walker 2008-01-02 16:21:47 UTC 
See bug 354462, comments 11-13 for more information.  The general problem seems to be that the gedit status bar implements accessible information that exposes the accessible information of its children.  This results in a redundancy of output from Orca.

One possible way to work around this problem is to only pursue the children of a status bar in flat review if we cannot get non-empty text information from the status bar.
Comment 1 Rich Burridge 2008-01-14 21:27:23 UTC 
Created attachment 102856 [details] [review]
Revision #1

Here's something that seems to work, but I suspect it's
not the right approach (due to my unfamiliarity with the
various flat review methods).

Will can you please review and suggest a better approach?

Thanks.
Comment 2 Willie Walker 2008-01-14 22:56:25 UTC 
Created attachment 102860 [details] [review]
Alternative patch

The patch you did looks good, and it definitely solves the problem.  You also did all the hard work, which includes finding the right spot to make the change.  :-)  This patch just simplifies things a little bit, using getZonesFromText to replace some of the guts.  It seems to work well for me.  Either patch is fine by me, though.
Comment 3 Rich Burridge 2008-01-14 23:05:08 UTC 
I like your version much better. Patch committed and closing as FIXED.
Thanks!
Comment 4 Willie Walker 2008-02-10 17:29:33 UTC 
Created attachment 104856 [details] [review]
Patch to address regression test

This patch addresses the new and improved output from the regression test perspective.