After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 506049 - Use pango_layout_set_height in GtkCalendar
Use pango_layout_set_height in GtkCalendar
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on: 469313
Blocks:
 
 
Reported: 2007-12-28 12:08 UTC by Mathias Hasselmann (IRC: tbf)
Modified: 2008-01-22 17:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] Use pango_layout_set_height() for calendar details (#506049). (3.01 KB, patch)
2008-01-22 13:20 UTC, Mathias Hasselmann (IRC: tbf) 		committed Details | Review
pango_layout_set_height in action (39.01 KB, image/png)
2008-01-22 13:21 UTC, Mathias Hasselmann (IRC: tbf) 		  Details

Description Mathias Hasselmann (IRC: tbf) 2007-12-28 12:08:35 UTC 
Once pango_layout_set_height is implemented, GtkCalendar should use it for rendering details.
Comment 1 Mathias Hasselmann (IRC: tbf) 2007-12-28 19:21:59 UTC 
Bah. Stupid Bugzilla search.
Comment 2 Mathias Hasselmann (IRC: tbf) 2008-01-22 13:20:10 UTC 
Created attachment 103432 [details] [review]
[PATCH] Use pango_layout_set_height() for calendar details (#506049).


* configure.in: Require 1.19.3 for pango_layout_set_height().
* gtk/gtkcalendar.c: Use pango_layout_set_height() for details.
---
 ChangeLog         |    7 +++++++
 configure.in      |    2 +-
 gtk/gtkcalendar.c |   35 ++++++++++-------------------------
 3 files changed, 18 insertions(+), 26 deletions(-)
Comment 3 Mathias Hasselmann (IRC: tbf) 2008-01-22 13:21:02 UTC 
Created attachment 103433 [details]
pango_layout_set_height in action
Comment 4 Matthias Clasen 2008-01-22 14:05:38 UTC 
Looks good to me. 

Just remove the C99 comment.
Comment 5 Mathias Hasselmann (IRC: tbf) 2008-01-22 15:03:28 UTC 
Thanks you, commited:

2008-01-22  Mathias Hasselmann  <mathias@openismus.com>

	Use pango_layout_set_height() for calendar details (#506049).

	* configure.in: Require 1.19.3 for pango_layout_set_height().
	* gtk/gtkcalendar.c: Use pango_layout_set_height() for details.
Comment 6 Behdad Esfahbod 2008-01-22 17:51:13 UTC 
Nice!!!  Thanks.