Created attachment 101534 [details] [review]
patch

Thanks Matthias. Please commit. 

Created attachment 101953 [details] [review]
Patch to get extension dir from libnautilus-extension.pc

How about using this patch instead?  That way we're not hard-coding the extension dir.

Yeah, I had considered that, but decided not to bother, since a change in the location generally goes along with an api change that warrants close inspection of the source anyway. I.e. you don't really want to blindly rebuild and install in the new location. Also, the patch adds yet more unnecessary configure goo; 
I'd just call pkg-config in the Makefile. 

Either way, not a big deal.

*** Bug 508808 has been marked as a duplicate of this bug. ***

I'm for a second patch actually

But applied first, it's really simplier. Thanks a lot to all.

I don't agree. We should have a decent fix, not a simpler happens-to-work fix. If API changes the build will break anyway, so it won't go unnotices if that happens.

Created attachment 102739 [details] [review]
Fix against current trunk

I'm about to commit this change.

2008-01-13  Wouter Bolsterlee  <wbolster@svn.gnome.org>

	* properties/Makefile.am:

	Get the nautilus extension dir properly instead of using
	a hack. Fixes bug #505359.

Hi,

I am reopening this bug report because the chosen solution to this problem in comment 9 causes an installation error when you do not have write permission in the global nautilus extension dir (e.g. /usr/lib/nautilus/extension-3.0) and you do:

$ configure --prefix=/tmp/local
$ make
$ make install

I will post a new proposed patch.

Created attachment 203605 [details] [review]
0001-Respect-prefix-when-installing-nautilus-extensions.patch

I'm about to commit this change.

If anyone has any objections, please let me know.

Review of attachment 203605 [details] [review]:

::: properties/Makefile.am
@@ +17,3 @@
 if ENABLE_NAUTILUS
 
+nautilusextensiondir=$(libdir)$(NAUTILUS_EXTENSION_DIR)

Isn't there a slash missing? or does libdir always have a trailing slash?

(In reply to comment #13)
> Review of attachment 203605 [details] [review]:
> 
> +nautilusextensiondir=$(libdir)$(NAUTILUS_EXTENSION_DIR)
> 
> Isn't there a slash missing? 

no,

> or does libdir always have a trailing slash?

no, but $(NAUTILUS_EXTENSION_DIR) has a leading slash.

(In reply to comment #13)
> Review of attachment 203605 [details] [review]:
> 
> +nautilusextensiondir=$(libdir)$(NAUTILUS_EXTENSION_DIR)
> 
> Isn't there a slash missing? 

no,

> or does libdir always have a trailing slash?

no, but $(NAUTILUS_EXTENSION_DIR) has a leading slash.

hmm, I would add the slash anyway, double slash should work too.