After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 505293 - Zoomer borders should only be displayed at source display intersection
Zoomer borders should only be displayed at source display intersection
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: magnification
2.21.x
Other All
: Normal enhancement
: 2.22.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on: 503073
Blocks:
 
 
Reported: 2007-12-23 20:03 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2008-07-22 19:33 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
revision 1 (4.42 KB, patch)
2007-12-23 20:06 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2007-12-23 20:03:00 UTC 
If the user enables a zoomer border and the zoomer is not occupying the entire screen, we display a border around the entire zoomer.  Ideally, we would only display a border where the zoomer/target display intersects with the source display.

Our ability to accomplish this depends on gnome-mag adding support for individual border sizes.
Comment 1 Joanmarie Diggs (IRC: joanie) 2007-12-23 20:06:26 UTC 
Created attachment 101519 [details] [review]
revision 1

Carlos has attached a patch to bug 503073.

This patch is based on his current patch (http://bugzilla.gnome.org/attachment.cgi?id=101497&action=view)

I tested this both with and without Carlos' patch.  Seems to work.  Without Carlos' patch, we continue to display the border around all four edges.  With the patch, we seem to display it in the correct location -- including with live updating.

Please test.  Thanks!
Comment 2 Rich Burridge 2008-01-02 18:15:03 UTC 
I can only test this for the case of using an old gnome-mag
(the latest from SVN HEAD won't build for me), but with that
older version of gnome-mag (the one that comes by default with
Ubuntu Gutsy), this patch seems to work just fine.
Comment 3 Joanmarie Diggs (IRC: joanie) 2008-01-02 19:48:39 UTC 
Thanks Rich.  Patch committed.  Moving to pending.
Comment 4 Willie Walker 2008-01-04 22:12:04 UTC 
The older version works well for me, too.  I'll upgrade my gnome-mag to try the latest.
Comment 5 Willie Walker 2008-01-04 22:22:07 UTC 
The latest gnome-mag works well with this, too, and your bug fix does what it says it is supposed to do.  I think you can close this as FIXED.  Thanks!
Comment 6 Joanmarie Diggs (IRC: joanie) 2008-01-04 23:29:19 UTC 
Woo hoo! :-)  Thanks.  Closing as FIXED.