After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 504869 - Key binding for folder expansion
Key binding for folder expansion
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Views: List View
2.20.x
Other All
: Normal minor
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-12-21 13:38 UTC by Udo van den Heuvel
Modified: 2010-07-11 20:05 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20

Attachments
Adds key binding for expanding and collapsing folders in list view (#504869) (1.42 KB, patch)
2010-07-05 21:17 UTC, Marcus Carlson 		needs-work Details | Review
Adds key binding for expanding and collapsing folders in list view (#504869) (1.49 KB, patch)
2010-07-09 22:19 UTC, Marcus Carlson 		committed Details | Review

Description Udo van den Heuvel 2007-12-21 13:38:46 UTC 
Please make Folder view in Nautilus Filebrowser navigable with keyboard like the Windows file explorer can be used with the keyboard (arrow keys to open folders in the tree view, etc)

Other information:
See the File Explorer as found in Windows 2000/Xp.
Comment 1 Allan Day 2010-06-21 11:35:31 UTC 
Confirming and adjusting title.
Comment 2 Marcus Carlson 2010-07-05 21:17:47 UTC 
Created attachment 165309 [details] [review]
Adds key binding for expanding and collapsing folders in list view (#504869)
Comment 3 Cosimo Cecchi 2010-07-05 23:44:16 UTC 
Review of attachment 165309 [details] [review]:

Looks good, except for the comment below.

::: src/file-manager/fm-list-view.c
@@ +985,3 @@
+		gtk_tree_view_get_cursor (tree_view, &path, NULL);
+		if (path) {
+			gtk_tree_view_expand_row (tree_view, path, FALSE);

You should free |path| here and below.
Comment 4 Marcus Carlson 2010-07-09 22:19:10 UTC 
Created attachment 165583 [details] [review]
Adds key binding for expanding and collapsing folders in list view (#504869)

> You should free |path| here and below.

Of course, thanks
Comment 5 Cosimo Cecchi 2010-07-11 18:24:12 UTC 
Review of attachment 165583 [details] [review]:

Thanks, looks good to me.
Comment 6 Marcus Carlson 2010-07-11 20:05:59 UTC 
Committed, marking as FIXED