GNOME Bugzilla – Bug 504567
"You have received 1 new messages."
Last modified: 2013-09-13 00:59:50 UTC
johnny, you added the following strings in /plugins/mail-notification/mail-notification.c, rev34702: if (!status_count) { char *folder; status_count = t->new; folder = em_utils_folder_name_from_uri (t->uri); msg = g_strdup_printf (_("You have received %d new messages\nin %s."), status_count, folder); g_free (folder); } else { status_count += t->new; msg = g_strdup_printf (_("You have received %d new messages."), status_count); } 1) please read http://live.gnome.org/TranslationProject/DevGuidelines/Plurals and add proper ngettext support. 2) %s is the folder, and for nearly every account this folder is named INBOX here. i wonder if it makes sense to use the account instead. 3) a translator comment could also be nice. is "%s" a folder, an account, or is it "You have received 90 new messages in 4 hours."? 3) if you fix these strings, please announce the string change to gnome-i18n@.
5) the folder string is not localized, it's in english.
#5 is basically fixed by srag's commit this morning
Johnny High Prio before you fly :) Atleast fix 1 and 3. I have fixed 5.
Created attachment 103861 [details] [review] Added ngettext.
Patch committed to trunk. rev 34912.