After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 504567 - "You have received 1 new messages."
"You have received 1 new messages."
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.22.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks: 236276
 
 
Reported: 2007-12-20 00:40 UTC by André Klapper
Modified: 2013-09-13 00:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Added ngettext. (1.38 KB, patch)
2008-01-28 06:25 UTC, Johnny Jacob
committed Details | Review

Description André Klapper 2007-12-20 00:40:17 UTC
johnny, you added the following strings in /plugins/mail-notification/mail-notification.c, rev34702:

if (!status_count) {
     char *folder;
     status_count = t->new;

     folder = em_utils_folder_name_from_uri (t->uri);
     msg = g_strdup_printf (_("You have received %d new messages\nin %s."),
         status_count, folder);
     
     g_free (folder);
} else {
     status_count += t->new;
     msg = g_strdup_printf (_("You have received %d new messages."),
         status_count);
}

1) please read http://live.gnome.org/TranslationProject/DevGuidelines/Plurals and add proper ngettext support.
2) %s is the folder, and for nearly every account this folder is named INBOX here. i wonder if it makes sense to use the account instead.
3) a translator comment could also be nice. is "%s" a folder, an account, or is it "You have received 90 new messages in 4 hours."?
3) if you fix these strings, please announce the string change to gnome-i18n@.
Comment 1 André Klapper 2007-12-20 01:08:40 UTC
5) the folder string is not localized, it's in english.
Comment 2 André Klapper 2008-01-02 14:21:09 UTC
#5 is basically fixed by srag's commit this morning
Comment 3 Srinivasa Ragavan 2008-01-02 14:25:58 UTC
Johnny High Prio before you fly :) Atleast fix 1 and 3. I have fixed 5.
Comment 4 Johnny Jacob 2008-01-28 06:25:14 UTC
Created attachment 103861 [details] [review]
Added ngettext.
Comment 5 Johnny Jacob 2008-01-28 06:32:22 UTC
Patch committed to trunk. rev 34912.