GNOME Bugzilla – Bug 504480
new dialog-less errors are too tall for the status bar
Last modified: 2013-09-13 00:59:58 UTC
Please describe the problem: I'm running Evolution 2.21.4 in Hardy. I love these new messages that are coming to the status bar, but when they appear they cause the entire status bar to grow taller. The issue seems to be that the contents of those boxes containing the error code and the little cancel button are too tall for the status bar - you can see the lower part of the evolution window re-draw when any message appears. To reproduce, all you have to do is click send/receive on the toolbar and observe the status bar redraw. Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
known issue.
Created attachment 101295 [details] [review] Proposed patch Increases the height of the ETaskBar to eliminate the constant resizing. Note that I fudged the height a bit to account for the button border, which is a style property that I couldn't figure out how to easily retrieve. Maybe someone else knows a better way.
Created attachment 101327 [details] [review] proposed evo patch for evolution; When we are talking about cheating, what about this? :) Btw, I fixed a possible leak too and other bug with unused parameter (it wasn't visible, because the hard coded value is same as the parameter in all calls, but anyway, it shouldn't be like that, either remove the parameter or use it. I hope you will agree.) Btw2, I didn't obsolete your patch, one can choose "the better" one.
Thanks for the patches guys. I'm on vacation and will be back on 1st of Jan and will test/choose the best one :)
Hmm, I'll push Matt's patch here. Milan, In the prepare_popup I wanted to add a menu to "Cancel" and "Cancel All" but I haven't got time to implement it. You almost take that off :) Can you just patch your leak fix alone?
Created attachment 102096 [details] [review] proposed evo patch (leak and prototype fix) for evolution; Sure, I can, I just wasn't CCed to this bug, so I didn't notice your request earlier :(
Matt's patch committed to trunk. Committed revision 34758. So this just waits for reject/approve of my leak and prototype fix.
Looks good, Milan. Please commit.
Second patch committed to trunk. Committed revision 34759.
I observed one little issue about this patch, when I open a menu and move mouse over the menu items with hint, the status bar is getting smaller when displaying the hint, and grow a bit again when moving over the item without the hint. Try this (everything with mouse): 1) Open Edit menu item 2) Move mouse between first item (Copy for me in mailer) and the separator just under that item. When you are over Copy, the height is a bit smaller. When you are over the separator, the height is back in taller state. It scared me again (a bit), until I realized what is going on.