After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 503527 - Mnemonics are not supported well
Mnemonics are not supported well
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: 2.22.0
Assigned To: Willie Walker
Orca Maintainers
Depends on:
Blocks: orca-java
 
 
Reported: 2007-12-14 01:22 UTC by Willie Walker
Modified: 2008-07-22 19:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to take mnemonics into account (22.70 KB, patch)
2007-12-14 01:27 UTC, Willie Walker 		committed Details | Review

Description Willie Walker 2007-12-14 01:22:08 UTC 
In tracking down some other Java platform problems, I noticed that mnemonics were not handled at all.  Instead, we look at only the full path and accelerator fields of a key binding for an event.

In Java, the only information we get for menus and menu items seems to be the mnemonic.  As such, this information is not available to the user in Orca's current form.
Comment 1 Willie Walker 2007-12-14 01:27:01 UTC 
Created attachment 100925 [details] [review]
Patch to take mnemonics into account

This patch takes mnemonics into account.  Most of the changes that an end user will see live in where_am_I.py, and it also fixes a bug in where_am_I.py that assumes the last character of the accelerator is the mnemonic:  from the "Open Tab" menu item in "File" menu of GNOME terminal, we see that the two can be different (Shift+Ctrl+T for the accelerator and 'b' for the mnemonic).

This patch also includes updated tests and all files have been pylint'ed to a 10.00.
Comment 2 Willie Walker 2007-12-14 01:31:44 UTC 
While I tested this patch by hand with Firefox, OOo, GTK+, and Java apps, and I also ran the gtk-demo regression tests (and updated them accordingly), I think it could still use some more testing.  Mike, please test.
Comment 3 Mike Pedersen 2007-12-14 18:33:38 UTC 
This one now seems to be working well.
Comment 4 Willie Walker 2007-12-14 20:28:58 UTC 
Committed.  Thanks!