Bug 503522 – Enabling full screen magnification fails miserably in Solaris

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 503522 - Enabling full screen magnification fails miserably in Solaris


Summary:	Enabling full screen magnification fails miserably in Solaris


Status:	RESOLVED FIXED

Product:	orca
Classification:	Applications
Component:	magnification
Version:	2.21.x
Hardware:	Other opensolaris

Importance:	Normal major
Target Milestone:	2.22.0
Assigned To:	Joanmarie Diggs (IRC: joanie)
QA Contact:	Orca Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2007-12-14 01:07 UTC by Joanmarie Diggs (IRC: joanie)
Modified:	2008-07-22 19:32 UTC

See Also:
GNOME target:	---
GNOME version:	2.19/2.20

Attachments
proposed patch (2.23 KB, patch) 2007-12-14 06:54 UTC, Joanmarie Diggs (IRC: joanie)	committed	Details \| Review

Description Joanmarie Diggs (IRC: joanie) 2007-12-14 01:07:56 UTC

From Will's comment on bug 463881:

Something is still askew with trying to force full screen as the default
setting.  When I select the enable magnifier checkbox, I get the following
output in the terminal where I ran Orca *and* all the controls on the magnifier
remain grayed out.  Without hand editing my user-preferences file, I cannot get
out of this situation.

Traceback (most recent call last):

+ Trace 181830

File "/usr/local/lib/python2.4/site-packages/orca/orca_gui_prefs.py", line 2634 in magnifierSupportChecked
```
mag.init()
```
File "/usr/local/lib/python2.4/site-packages/orca/mag.py", line 878 in init
```
applySettings()
```
File "/usr/local/lib/python2.4/site-packages/orca/mag.py", line 779 in applySettings
```
__setupZoomer()
```
File "/usr/local/lib/python2.4/site-packages/orca/mag.py", line 617 in __setupZoomer
```
raise RuntimeError, "Nothing can be magnified"
```

RuntimeError: Nothing can be magnified

Comment 1 Joanmarie Diggs (IRC: joanie) 2007-12-14 01:13:30 UTC

I do not have this problem in OpenSolaris with the latest gnome-mag and composite enabled or disabled in my xorg.conf.  If composite is enabled, full screen works as expected.  If composite is not enabled, split screen kicks in as expected.  It is the latest gnome-mag that informs us if we are full-screen capable at the moment, so we need to add some more smarts to Orca for users who don't have the latest gnome mag.

I assume this is a side effect of bug 452316.  

Assigning it to myself as Will and I are the ones with current Solaris/OpenSolaris boxes.

Comment 2 Joanmarie Diggs (IRC: joanie) 2007-12-14 06:54:51 UTC

Created attachment 100936 [details] [review]
proposed patch

I was able to reproduce the problem on a clean install of OpenSolaris (77).  This patch solves it for me.  Will, please test.  Thanks!

Comment 3 Willie Walker 2007-12-14 16:24:57 UTC

Woo woo!  Works for me.  Thanks!

Comment 4 Joanmarie Diggs (IRC: joanie) 2007-12-14 16:54:44 UTC

(In reply to comment #3)
> Woo woo!  

Indeed!! :-)  Thanks for testing.  Sorry about the breakage.  I will leave a laptop in a pure, unadulterated Solaris state -- not counting the installation of Emacs :-)  -- so this sort of thing doesn't happen again.

Moving to pending.

Comment 5 Willie Walker 2008-01-04 21:51:22 UTC

I think this probably can be closed as FIXED.  Thanks!

Comment 6 Joanmarie Diggs (IRC: joanie) 2008-01-04 23:34:10 UTC

Thanks.  Closing as FIXED.