GNOME Bugzilla – Bug 502278
jhbuild should reconfigure tarballs when -a specified
Last modified: 2007-12-18 15:22:59 UTC
Jhbuild should reconfigure tarballs when -a specified. eg, if the user specified: jhbuild buildone -a libxklavier libxklavier should be reconfigured.
Created attachment 100503 [details] [review] reconfigure tarballs is always autogen is requested.
That's fine; do you have commit rights or do you want me to apply it?
I don't have commit rights. Looking for someone to vouch for me. Volunteering? :)
Created attachment 100564 [details] [review] Only unpack tarball if necessary I suggest apply this patch at the same time as attachment 100503 [details] [review], although the patches are independent. This patch only unpacks the tarball if the directory doesn't exist. This is useful if the developer has made some changes to the extracted tarball code, and then wants to reconfigure it with the '-a' switch. The clobber mode still works as before. (Because clobber removes the directory, see method 'do_start' in modtypes/tarball.py)
Created attachment 100565 [details] [review] Only unpack tarball if necessary and handle patching My patch attachment 100564 [details] [review] didn't handle patching of the tarball correctly. With this patch: if the directory already exists, don't unpack and don't re-apply the patches.
I just commited both patches. 2007-12-15 Frederic Peters <fpeters@0d.be> * jhbuild/modtypes/tarball.py: only unpack tarball if necessary, patch by Craig Keogh. 2007-12-15 Frederic Peters <fpeters@0d.be> * jhbuild/modtypes/tarball.py: reconfigure tarballs when -a specified, patch by Craig Keogh (closes: #502278)
*** Bug 365347 has been marked as a duplicate of this bug. ***