After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 501733 - Syntax highlighting for IDL wanted
Syntax highlighting for IDL wanted
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: Syntax files
2.0.x
Other Linux
: Normal enhancement
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2007-12-05 13:22 UTC by Pedro Villavicencio
Modified: 2012-12-22 10:24 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20


Attachments
IDL Lang file (17.74 KB, application/octet-stream)
2012-11-11 21:56 UTC, Timothy Arceri
  Details
IDL Lang file v2 (19.07 KB, application/octet-stream)
2012-11-11 22:56 UTC, Timothy Arceri
  Details
IDL Lang file v3 (19.20 KB, application/octet-stream)
2012-11-12 00:53 UTC, Timothy Arceri
  Details
IDL Lang file v4 (22.20 KB, patch)
2012-11-12 01:22 UTC, Timothy Arceri
none Details | Review
IDL Lang file v5 (22.13 KB, patch)
2012-11-12 03:19 UTC, Timothy Arceri
none Details | Review
IDL Lang file v6 (22.02 KB, patch)
2012-12-22 09:09 UTC, Timothy Arceri
none Details | Review

Description Pedro Villavicencio 2007-12-05 13:22:59 UTC
This report has been filled here:

https://bugs.launchpad.net/ubuntu/+source/gedit/+bug/172906

"When I open up an IDL script (*.pro) I don't get offered syntax highlighting. I've tried to enable it in the gedit options and still nothing.

Using Kate (KDE Editor) I get the syntax highlighting to work straight away. I'm using 7.10 but I had the same problem with 7.04."

IDL script: http://launchpadlibrarian.net/10728620/cpt.pro

Thanks,
Comment 1 Paolo Maggi 2007-12-30 08:40:54 UTC
Which is the mime-type of the file according to Nautilus?

Note that gtksourceview supports CORBA IDL but not the IDL language used in the sample.  
Comment 2 Yevgen Muntyan 2007-12-30 19:41:31 UTC
As far as I can tell, f.d.o. database doesn't have a mime type for this IDL language. But it's not such a big deal comparing to the fact that there is no lang file, or is there?
Comment 3 Pedro Villavicencio 2008-01-09 12:24:34 UTC
the mime-type according to nautilus is text/plain
Comment 4 Paolo Borelli 2009-12-29 14:44:11 UTC
Closing... if someone creates a lang file we'll consider it, but until then no point keeping this open.
Comment 5 Raphael Freudiger 2010-03-22 17:12:48 UTC
On http://www.ipgp.fr/~lucas/IDL_on_Gedit.html there's a language file for idl which is not too bad. It highlights at least much more than the current idl highlighting.
Comment 6 Daniel Münch 2010-11-09 16:27:58 UTC
I am using the above file now, it is great finally having some highlighting, would be cool if it could be included!
Comment 7 Timothy Arceri 2012-11-11 21:56:16 UTC
Created attachment 228738 [details]
IDL Lang file

Attached the lang file as I have requested via the mailing list that it be added. Also I renamed it from idl-itt to idl-exelis as the company has had a name change.
Comment 8 Timothy Arceri 2012-11-11 22:56:46 UTC
Created attachment 228740 [details]
IDL Lang file v2

ok I've fixed some a couple of errors in the old file and added a whole heap of missing functions and keywords
Comment 9 Timothy Arceri 2012-11-12 00:53:38 UTC
Created attachment 228743 [details]
IDL Lang file v3

A few more fixs and additions
Comment 10 Timothy Arceri 2012-11-12 01:22:23 UTC
Created attachment 228744 [details] [review]
IDL Lang file v4

Ok, I've cleaned up the formatting and turned it into a patch
Comment 11 Timothy Arceri 2012-11-12 03:19:48 UTC
Created attachment 228746 [details] [review]
IDL Lang file v5

Fixed escaping of strings
Comment 12 Paolo Borelli 2012-11-12 22:18:19 UTC
Reopening or it will get lost (feel free to reopen in these cases)
Comment 13 Timothy Arceri 2012-12-06 00:09:44 UTC
What else needs to be provided to get this patch accepted?
Comment 14 Paolo Borelli 2012-12-06 09:34:05 UTC
Review of attachment 228746 [details] [review]:

What is missing is time and strength to review :-)

A couple of comments below and we are good to go

::: data/language-specs/idl-exelis.lang
@@ +21,3 @@
+<language id="idl-exelis" _name="IDL-Exelis" version="2.0" _section="Scientific">
+  <metadata>
+    <property name="mimetypes">text/x-idl</property>

is this an official mime type included in shared-mime-info? If not, let's remove it, this metadata is not mandatory

@@ +77,3 @@
+    <context id="operators" style-ref="keyword">
+      <keyword>TRUE</keyword>
+      <keyword>FALSE</keyword>

are TRUE and FALSE operators?
Comment 15 Timothy Arceri 2012-12-22 09:09:51 UTC
Created attachment 232108 [details] [review]
IDL Lang file v6

Removed mime type.
Remove TRUE/FALSE operators they should not have been there, IDL does not even have Boolean types.
Comment 16 Paolo Borelli 2012-12-22 10:24:34 UTC
Thanks for your patience.

I committed with some amendments (noted here if you happen to submit lang files in the future)

 - added the file to Makefile.am
 - added the file to POTFILES.in
 - removed the "types" style that as far as I can see was not used