After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 501117 - [a11y] GtkIconView does not expose STATE_SELECTED to ATs
[a11y] GtkIconView does not expose STATE_SELECTED to ATs
Status: RESOLVED DUPLICATE of bug 499835
Product: atk
Classification: Platform
Component: gail
unspecified
Other Linux
: Urgent normal
: ---
Assigned To: Li Yuan
Li Yuan
Depends on:
Blocks: 486909
 
 
Reported: 2007-12-02 21:21 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2008-02-19 10:23 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
patch for adding selected state to iconview (567 bytes, patch)
2008-01-21 09:54 UTC, LiYan.Zhang
none Details | Review

Description Joanmarie Diggs (IRC: joanie) 2007-12-02 21:21:37 UTC
Steps to reproduce:

1. Launch Accerciser
   (http://live.gnome.org/Accerciser)

2. Launch gtk-demo's Icon View Basics

3. Select one or more icons

4. In the tree on the left in Accerciser, browse to a selected icon

5. On the right-hand side in Accerciser, choose the Interface Viewer
   and expand Accessible

Expected results:  "selected" would appear in the list of states

Actual results: "selected" does not appear in the list of states

Compare to Nautilus (version 2.20.0) which is providing the expected information.

This is an accessibility issue because the lack of STATE_SELECTED prevents ATs from being able to present how many icons are currently selected to users who are blind.

Thanks in advance!
Comment 1 Willie Walker 2008-01-06 17:05:31 UTC
Li, any ideas on this one?
Comment 2 Li Yuan 2008-01-07 02:32:10 UTC
I didn't notice this bug because I didn't monitor gtk+ bugs (maybe I should in the future). It seems like a gail bug to me, transferring it to gail and I will look at it this week.
Comment 3 Li Yuan 2008-01-08 06:04:58 UTC
Oh, sorry, the accessibility code for gtkiconview is in gtk. Anyway, I will try to fix this one and Bug #499835 together.
Comment 4 Willie Walker 2008-01-08 14:20:16 UTC
(In reply to comment #3)
> Oh, sorry, the accessibility code for gtkiconview is in gtk. Anyway, I will try
> to fix this one and Bug #499835 together.
> 

Sounds great.  Thanks!  If you can make sure we have the necessary fix(es) that will work for the old and new versions (i.e., old = GAIL separate from GTK+, new = GAIL rolled into GTK+), it will help us greatly with GNOME 2.22 and beyond.  That is, the new version won't be released for GNOME 2.22 as far as I can tell.  See http://bugzilla.gnome.org/show_bug.cgi?id=169488#c28 of bug #169488 for more information. 
Comment 5 LiYan.Zhang 2008-01-21 09:54:16 UTC
Created attachment 103317 [details] [review]
patch for adding selected state to iconview

When Orca wants to refer the state set of IconView, the function gtk_icon_view_item_accessible_ref_state_set will
judge whether the item has been selected. If yes, STATE_SELECTED
will be added; otherwise, STATE_SELECTED will be removed.
Comment 6 Willie Walker 2008-01-22 14:24:28 UTC
(In reply to comment #5)
> Created an attachment (id=103317) [edit]
> patch for adding selected state to iconview
> 
> When Orca wants to refer the state set of IconView, the function
> gtk_icon_view_item_accessible_ref_state_set will
> judge whether the item has been selected. If yes, STATE_SELECTED
> will be added; otherwise, STATE_SELECTED will be removed.
> 

Thanks!  I'm not sure of what the status of GTK+ is these days with respect to what's shipping with GNOME 2.22 and what's slated for a later release.  If this can get into a GNOME 2.22 release, it would be great.  Thanks!
Comment 7 Li Yuan 2008-02-19 10:23:52 UTC

*** This bug has been marked as a duplicate of 499835 ***