After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 501070 - Missing Help button
Missing Help button
Status: RESOLVED FIXED
Product: system-monitor
Classification: Core
Component: general
2.20.x
Other All
: Normal enhancement
: ---
Assigned To: System-monitor maintainers
System-monitor maintainers
Depends on:
Blocks:
 
 
Reported: 2007-12-02 17:57 UTC by misakmilan
Modified: 2011-11-11 10:03 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
Patch to add the Help button to the preferences dialog (1.71 KB, patch)
2011-07-08 21:54 UTC, Robert Roth 		committed Details | Review
Add Help button to the preferences dialog (1.87 KB, patch)
2011-07-11 00:34 UTC, Chris Kühl 		committed Details | Review

Description misakmilan 2007-12-02 17:57:08 UTC 
There could be Help button on bottom left side of the Edit-Preferences dialog
Comment 1 Robert Roth 2011-07-08 21:19:31 UTC 
THe GNOME HIG also states that Preference windows might have a Help button, but it's not mandatory [1], so this should be set as a wishlist item, enhancement. 

[1] http://developer.gnome.org/hig-book/3.0/hig-book.html#preference-windows
Comment 2 Robert Roth 2011-07-08 21:20:06 UTC 
And also marked as NEW, as this is a valid request, which can be confirmed.
Comment 3 Robert Roth 2011-07-08 21:54:14 UTC 
Created attachment 191540 [details] [review]
Patch to add the Help button to the preferences dialog

I have attached a simple patch, that shows a help button on the left side of the preferences dialog's action area, and when clicked, displays the preferences section of the current help document.
Comment 4 Chris Kühl 2011-07-11 00:34:42 UTC 
The following fix has been pushed:
6bd176c Add Help button to the preferences dialog

Thanks. Please use 'git format-patch' to create the patch next time.
Comment 5 Chris Kühl 2011-07-11 00:34:49 UTC 
Created attachment 191658 [details] [review]
Add Help button to the preferences dialog
Comment 6 Robert Roth 2011-07-11 06:12:40 UTC 
I have created the patch from git master using the command `git format-patch origin`. What was wrong with the patch? Just asking to know what should I do differently next time.
Comment 7 Chris Kühl 2011-07-11 08:43:34 UTC 
You're absolutely right! Sorry. :P

Thanks again.