After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 500947 - port to gtk 2.12 tooltips
port to gtk 2.12 tooltips
Status: RESOLVED FIXED
Product: glade
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Glade 3 Maintainers
Glade 3 Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-12-01 23:40 UTC by Christian Persch
Modified: 2007-12-19 13:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (24.67 KB, patch)
2007-12-01 23:48 UTC, Christian Persch
none Details | Review
updated patch (25.36 KB, patch)
2007-12-01 23:58 UTC, Christian Persch
committed Details | Review

Description Christian Persch 2007-12-01 23:40:01 UTC
And remove the event box under the labels in the property view which existed only to support tooltips on them.
Comment 1 Christian Persch 2007-12-01 23:48:52 UTC
Created attachment 100014 [details] [review]
patch
Comment 2 Christian Persch 2007-12-01 23:58:04 UTC
Created attachment 100015 [details] [review]
updated patch

Fixes the tooltips on the palette to only show in ICONS_ONLY mode.
Comment 3 Tristan Van Berkom 2007-12-02 05:18:37 UTC
Very cool, I havent branched yet and will try to get that
done in the next couple of days (since I cant put this in
stable).

One thing I wonder, shouldnt we be using g_utf8_collate()
to compare strings that are returned by gettext() ? 
Comment 4 Christian Persch 2007-12-02 12:29:42 UTC
-	if (g_utf8_collate (name, _("Accessibility")) == 0)
+	if (strcmp (name, _("Accessibility")) == 0)

It's not a huge issue, but here we want to test for strict equality (the tab is named exactly _("Accessibility"), not something that sorts the same as it); g_utf8_collate should be used when sorting results.
Comment 5 Tristan Van Berkom 2007-12-18 16:43:36 UTC
ok now I know the difference thanks for clarifying.

So I branched out gnome-2-20 finally - whew.

Can you please commit these changes to trunk ?
Comment 6 Christian Persch 2007-12-19 13:50:19 UTC
Note that due to gtk bug 504456, there will be some empty tooltips shown.

        * configure.ac:
        * gladeui/glade-app.c: (glade_app_refresh_undo_redo_button):
        * gladeui/glade-base-editor.c: (glade_base_editor_add_properties):
        * gladeui/glade-editor-property.c:
        (glade_editor_property_tooltip_cb),
        (glade_editor_property_sensitivity_cb),
        (glade_editor_property_create_info_button),
        (glade_editor_property_constructor),
        (glade_editor_property_finalize),
        (glade_editor_property_load_common),
        (glade_eprop_text_show_i18n_dialog),
        (glade_eprop_adjustment_table_add_label):
        * gladeui/glade-editor-property.h:
        * gladeui/glade-editor.c: (glade_editor_notebook_page),
        (glade_editor_create_info_button),
        (glade_editor_create_reset_button),
        (glade_editor_table_append_item):
        * gladeui/glade-palette.c: (glade_palette_dispose),
        (glade_palette_new_item), (glade_palette_new_item_group),
        (glade_palette_update_appearance), (glade_palette_init):
        * gladeui/glade-project.c: (glade_project_dispose),
        (glade_project_init):
        * gladeui/glade-project.h:
        * gladeui/glade-property-class.c:
        (glade_property_class_new_from_spec):
        * gladeui/glade-utils.c:
        * gladeui/glade-widget.c: (expose_draw_selection):
        * plugins/gtk+/glade-gtk.c: (glade_gtk_widget_set_property),
        (glade_gtk_widget_get_property):
        * src/glade-window.c: (format_project_list_item_tooltip),
        (refresh_projects_list_menu), (glade_window_init): Port to gtk 2.12
        tooltips API. Bug #500947. Remove the unnecessary event boxes on the property
        labels, part of bug #490157.