GNOME Bugzilla – Bug 499234
gdkpixbuf: add gdkpixbufoverlay element
Last modified: 2012-04-23 16:40:09 UTC
A new element to put a pixbuf over the video stream. pipe to test: gst-launch filesrc location=[video file] ! decodebin ! gdkpixbufoverlay image-name=[image name] ! xvimagesink decompress the glue tar file on gst-plugins-good folder and apply the patch
Created attachment 99551 [details] [review] patch
Created attachment 99552 [details] new files
Could this not be done with videomixer?
videomixer isn't really the most convenient to just overlay a logo, is it? In any case, my impression is that the code of this pixbufoverlay is not even close to being in a state where it could/should be considered for inclusion into -good (IMHO).
Renato, I think it is better to put it on gst-plugins-bad. Then let people know sending a mail to the list. After that more people get involved. BR, Edgard
Created attachment 109053 [details] Modification of gdkpixbufoverlay decompress the glue2 tar file on gst-plugins-good folder and apply the patch Renato published. -add opacity property -support 4 and 3 channels images -pre-compute rgb2yuv matrices
Approximately 3 months from now will be the first birthday of this patch. I am interested in it, and while I can build the component by myself, having it integrated in an official gstreamer distributions considerably eases work. Is it considered for inclusion in gst-plugins-bad, and if not, what can be done about it ?
oliver, if can consolidate the changes into a patch that applies to gst-plugins-bad that would help to get it into -bad.
(In reply to comment #8) > oliver, if can consolidate the changes into a patch that applies to > gst-plugins-bad that would help to get it into -bad. I have done that, and a new bug report #550443 has been created to track it.
Let's stick to this bug (we can change components if we need to). I think it makes more sense to get this widget into shape and add it to the existing gdkpixbuf plugin. The main reason that hasn't happened yet is probably that the code isn't quite ready yet. It looks like gdkpixbufoverlay was based on the pango textoverlay element, which is not a good element to base this on, since it has two input pads and needs to do all kinds of things you don't need to deal with in gdkpixbufoverlay. So there's quite a bit of weird code in there that doesn't need to be in there. The element should probably be based on GstVideoFilter (which is based on GstBaseTransform).
This bug has been set to NEEDINFO in comment #3. As the question has been answered by now, I am reopening this bug.
Code still needs serious clean-up as said in comment #10. Since it's an enhancement bug, we may just as well set it to NEW. One day someone will get to it, I'm sure (had it on my lis for ages, but never got around to it, sorry).
Any news on this?
commit 729a30c38b2aacfac9aa6454d7037e08c1416557 Author: Tim-Philipp Müller <tim.muller@collabora.co.uk> Date: Sat Mar 17 20:18:19 2012 +0000 gdkpixbuf: add gdkpixbufoverlay element Still lacks features such as positioning or resizing, or animations, but it's usable already, and supports lots of formats.