After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 498107 - Add "save all files" option in diff dialog
Add "save all files" option in diff dialog
Status: RESOLVED FIXED
Product: anjuta
Classification: Applications
Component: Plugins: subversion
SVN TRUNK
Other Linux
: Normal normal
: ---
Assigned To: Johannes Schmid
Anjuta maintainers
Depends on:
Blocks:
 
 
Reported: 2007-11-19 08:06 UTC by James Liggett
Modified: 2007-11-20 22:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Adds option to save open files before diffing, active by default (20.70 KB, patch)
2007-11-19 09:07 UTC, James Liggett
committed Details | Review
New patch, now with no bugs :) (21.35 KB, patch)
2007-11-20 09:35 UTC, James Liggett
committed Details | Review

Description James Liggett 2007-11-19 08:06:15 UTC
From bug 457477:

The diff dialog should have a checkbox, enabled by default, that allows the user to make sure that all open files are saved before diffing.
Comment 1 James Liggett 2007-11-19 09:07:14 UTC
Created attachment 99321 [details] [review]
Adds option to save open files before diffing, active by default
Comment 2 Johannes Schmid 2007-11-19 22:40:54 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.

Thanks for the patch!
Comment 3 James Liggett 2007-11-20 09:33:11 UTC
Reopening bug...my last patch was wrong :(
Comment 4 James Liggett 2007-11-20 09:35:20 UTC
Created attachment 99383 [details] [review]
New patch, now with no bugs :)

This one has the include that the last one was missing, so the plugin should load after applying it. 

Sorry for the trouble...:(
Comment 5 Naba Kumar 2007-11-20 13:25:23 UTC
(In reply to comment #4)
> Created an attachment (id=99383) [edit]
> New patch, now with no bugs :)
> 
> This one has the include that the last one was missing, so the plugin should
> load after applying it. 
> 
This has been applied. Does it also contain the patch in http://bugzilla.gnome.org/show_bug.cgi?id=498044?
Comment 6 Naba Kumar 2007-11-20 13:30:35 UTC
(In reply to comment #5)
> This has been applied. Does it also contain the patch in
> http://bugzilla.gnome.org/show_bug.cgi?id=498044?
> 
At least I don't see the dialogs being resizable, but the patch in bug #498044
does not apply.
Comment 7 James Liggett 2007-11-20 22:26:02 UTC
> This has been applied. Does it also contain the patch in
> http://bugzilla.gnome.org/show_bug.cgi?id=498044?
No, they are separate changes. I've noticed that Glade 3 likes to make a lot of extraneous changes to XML files. That, and I did make a few changes to the diff dialog for this patch.  

> At least I don't see the dialogs being resizable, but the patch in bug #498044
> does not apply.
I'll update my copy and give you a patch that will apply. Sigh...:(