After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 497237 - Build system does not rebuild parser
Build system does not rebuild parser
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Robert Ancell
gcalctool maintainers
Depends on:
Blocks:
 
 
Reported: 2007-11-15 23:22 UTC by Robert Ancell
Modified: 2007-11-16 13:16 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
Fixes parser dependencies in gcalctool/Makefile.am (1.77 KB, patch)
2007-11-16 13:08 UTC, Robert Ancell
committed Details | Review

Description Robert Ancell 2007-11-15 23:22:12 UTC
When the calctool.h header file is changed the parser needs to be rebuilt but the make system is not detecting this. Also make clean does not delete the autogenerated parser .c files.

To reproduce:
1. Check out gcalctool
2. Build gcalctool
3. Change calctool.h, some files will be rebuilt but the parser will not
4. Do a make clean
5. do a 'svn status gcalctool/'. A number of .c files and a .a file are there marked as 'I' (ignore). These files should have been removed by the make clean.
Comment 1 Robert Ancell 2007-11-15 23:28:10 UTC
The problem this causes is when the exprm_state structure or the 'v' structure is changed the parser tends to break and return 'Malformed Expression' errors due to accessing the structures in the old way.
Comment 2 Robert Ancell 2007-11-16 13:08:33 UTC
Created attachment 99206 [details] [review]
Fixes parser dependencies in gcalctool/Makefile.am

Seems to do the trick...