GNOME Bugzilla – Bug 496548
Including malloc.h breaks macos build
Last modified: 2007-11-14 11:13:26 UTC
The fft code Includes malloc.h, which breaks on mac os x. I don't think any sane unix requires you to do that, since malloc is part of stdlib and that header is already included in those files. I can't say for sure that some obscene OS will break if include is removed though. Will attach a patch.
Created attachment 99049 [details] [review]
Remove malloc includes
Thanks for reporting. The patch is of course correct, marking this as a blocker so we maybe can get this fixed before the release.
Seeing this bug makes me miss gst-lint.
Yes, this needs fixing before the release - 'Doesn't build on OSX' is a bad regression.
I don't think our fft module should be using malloc at all - we have g_malloc and g_free to avoid things like this on b00nky os'es
I'm not doing releases tonight then. Someone, please give me a patch
Created attachment 99062 [details] [review]
A patch that makes it use g_malloc/g_free instead, I mean.
Anyone unhappy with this patch?
Looks good to me and works fine...
Thanks for the quick responses here :) Patch looks good to me too.
looks fine to me
Fixed in CVS:
2007-11-14 Jan Schmidt <email@example.com>
Don't include malloc.h which doesn't exist on Mac OSX.
Instead, pull in glib.h and use g_malloc/g_free for
consistency. Fixes: #496548