After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 496402 - Evolution Automatic Contacts Plugin not excluding blocked users
Evolution Automatic Contacts Plugin not excluding blocked users
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Contacts
2.12.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Sankar P
Evolution QA team
Depends on: 496398
Blocks:
 
 
Reported: 2007-11-13 10:20 UTC by Kandepu Prasad
Modified: 2008-01-10 18:20 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20


Attachments
proposed evo patch (5.05 KB, patch)
2007-12-21 17:05 UTC, Milan Crha
committed Details | Review

Description Kandepu Prasad 2007-11-13 10:20:38 UTC
This is an upstream of Opensuse 10.3 bug in BNC
https://bugzilla.novell.com/show_bug.cgi?id=335070


The Evolution Automatic Contacts Plugin includes a feature to automatically
import buddies from your Instant Messaging accounts into the Evolution address
book.  This is a great feature, and I commend the author for this plugin.

One drawback.  AIM keeps blocked names in their list.  These blocks are
indicated by a 'blocked' icon.  Commonly, we block spammers coming to us over
instant messaging.  

Unfortunately, the Automatic Contacts plugin apparently does not recognize
blocked users on the list and imports them.  I have about 75 spammers now
listed in my Evolution address book.  :-)  I really don't think we want our
address books cluttered with spammer addresses.

The only way, currently, to avoid this is to remove those names from our list. 
But then that opens up spammers to come after us again.

The Automatic Contacts plugin does not have configurable options.  In the
spirit of freedom of choice, perhaps we can add a configurable option to allow
us to exclude blocked names.

*Note:  I've been told to redirect Evolution stuff to bugzilla.gnome.org, but
since this is a specific plugin written by Nat Friedman at Novell, I'm assuming
I'm filing in the right place here.

Comments
------- Comment #1 From Sankar P 2007-10-19 04:10:37 MST [reply] -------

I do not understand why you want to keep a blocked user in your pidgin
buddies-list. 

This bug report about bbdb reminded me about some changes that I did sometime
back. With that all email addresses to whom you send a mail, will be added to
your Evolution Addressbook (instead of those to whom you reply).

------- Comment #2 From Sankar P 2007-10-19 04:12:42 MST [reply] -------

Created an attachment (id=179411) [details]
Fix

This patch will fix the problem of blocked buddies getting synced to
Evo-Contacts. Let me know once this bug is upstreamed in b.g.o so that I can
commit the patch.

------- Comment #3 From Bryen Yunashko 2007-10-19 06:34:36 MST [reply] -------

Regarding Comment#1 ...  "I do not understand why you want to keep a blocked
user in your pidgin buddies-list."   Answer:  Not my choice.  That's just how
AIM sets up their block methodology.  But without keeping them in the list as
"blocked", then they are able to continue to IM me.  

Regarding Comment#2...  How do I download this attachment?  I'd love to test
out the fix and report back to you.  But everytime I click on attachment, I get
text rather than an actual file to download.
Comment 1 Milan Crha 2007-12-21 17:05:48 UTC
Created attachment 101421 [details] [review]
proposed evo patch

for evolution;

I hope Sankar will not be unhappy that I stole him this bug.
Comment 2 André Klapper 2007-12-21 20:27:49 UTC
@milan: no problem, it was only his *bug*, not his *car* (giggle).
(you're allowed to make two prejudice-jokes about me the next time.)
Comment 3 Sankar P 2007-12-24 05:45:26 UTC
Milan: I wish the patch was also upstreamed along with the bug :(

https://bugzilla.novell.com/attachment.cgi?id=179411 
Comment 4 Sankar P 2007-12-24 05:47:35 UTC
(In reply to comment #3)
> Milan: I wish the patch was also upstreamed along with the bug :(


The patch was not committed for SuSE also. We thought we will commit it to Gnome SVN and hence it automatically comes for next release. But bad that the patch was missed everywhere.

Kandepu Prasad: Here after if you are upstreaming a bug, and if the bnc bug has a patch, can you upstream it as well ? 

> 
> https://bugzilla.novell.com/attachment.cgi?id=179411 
> 

Comment 5 Kandepu Prasad 2007-12-24 05:55:10 UTC
Sorry, my mistake. I'll take care from next time.
Comment 6 Srinivasa Ragavan 2008-01-01 10:20:23 UTC
Sankar, Do you approve the patch?
Comment 7 Srinivasa Ragavan 2008-01-10 16:37:28 UTC
Milan Commit this. I have got a nod from Sankar.
Comment 8 Milan Crha 2008-01-10 18:20:21 UTC
Committed to trunk. Committed revision 34795.